Merge branch 'PX4:main' into mavlink_secure

Author: yulianoifa-mobius

.github/workflows/clang-tidy.yml

@@ -19,12 +19,12 @@ jobs:
       with:
         fetch-depth: 0
 
-    - name: Testing (clang-tidy-quiet)
+    - name: Testing (clang-tidy)
       uses: addnab/docker-run-action@v3
       with:
         image: px4io/px4-dev-clang:2021-09-08
         options: -v ${{ github.workspace }}:/workspace
         run: |
           cd /workspace
           git config --global --add safe.directory /workspace
-          make clang-tidy-quiet
+          make clang-tidy

.github/workflows/compile_macos.yml

@@ -34,7 +34,13 @@ jobs:
     - uses: actions/checkout@v4
 
     - name: setup
-      run: ./Tools/setup/macos.sh; ./Tools/setup/macos.sh
+      run: |
+        ./Tools/setup/macos.sh
+        ./Tools/setup/macos.sh
+        brew unlink gcc-arm-none-eabi
+        brew tap osx-cross/arm
+        brew install arm-gcc-bin@13
+        brew link --force arm-gcc-bin@13
 
     - name: Prepare ccache timestamp
       id: ccache_cache_timestamp

.gitmodules

@@ -92,3 +92,6 @@
 [submodule "test/fuzztest"]
 	path = test/fuzztest
 	url = https://github.com/google/fuzztest.git
+[submodule "src/lib/tensorflow_lite_micro/tflite_micro"]
+	path = src/lib/tensorflow_lite_micro/tflite_micro
+	url = https://github.com/PX4/tflite-micro.git

Makefile

@@ -468,7 +468,7 @@ python_coverage:
 
 # static analyzers (scan-build, clang-tidy, cppcheck)
 # --------------------------------------------------------------------
-.PHONY: scan-build px4_sitl_default-clang clang-tidy clang-tidy-fix clang-tidy-quiet
+.PHONY: scan-build px4_sitl_default-clang clang-tidy clang-tidy-fix
 .PHONY: cppcheck shellcheck_all validate_module_configs
 
 scan-build:
@@ -494,10 +494,6 @@ clang-tidy: px4_sitl_default-clang
 clang-tidy-fix: px4_sitl_default-clang
 	@cd "$(SRC_DIR)"/build/px4_sitl_default-clang && "$(SRC_DIR)"/Tools/run-clang-tidy.py -header-filter=".*\.hpp" -j$(j_clang_tidy) -fix -p .
 
-# modified version of run-clang-tidy.py to return error codes and only output relevant results
-clang-tidy-quiet: px4_sitl_default-clang
-	@cd "$(SRC_DIR)"/build/px4_sitl_default-clang && "$(SRC_DIR)"/Tools/run-clang-tidy.py -header-filter=".*\.hpp" -j$(j_clang_tidy) -p .
-
 # TODO: Fix cppcheck errors then try --enable=warning,performance,portability,style,unusedFunction or --enable=all
 cppcheck: px4_sitl_default
 	@mkdir -p "$(SRC_DIR)"/build/cppcheck

ROMFS/px4fmu_common/init.d-posix/rcS

@@ -190,6 +190,9 @@ param set-default SYS_FAILURE_EN 1
 # does not go below 50% by default, but failure injection can trigger failsafes.
 param set-default COM_LOW_BAT_ACT 3
 
+# set default IP to localhost
+param set-default UXRCE_DDS_AG_IP 2130706433  # 127.0.0.1
+
 
 # Adapt timeout parameters if simulation runs faster or slower than realtime.
 if [ -n "$PX4_SIM_SPEED_FACTOR" ]; then
@@ -319,7 +322,7 @@ then
 	uxrce_dds_port="$PX4_UXRCE_DDS_PORT"
 fi
 
-uxrce_dds_client start -t udp -h 127.0.0.1 -p $uxrce_dds_port $uxrce_dds_ns
+uxrce_dds_client start -t udp -p $uxrce_dds_port $uxrce_dds_ns
 
 if param greater -s MNT_MODE_IN -1
 then
@@ -342,11 +345,7 @@ then
 	gyro_calibration start
 fi
 
-# Payload deliverer module if gripper is enabled
-if param compare -s PD_GRIPPER_EN 1
-then
-	payload_deliverer start
-fi
+payload_deliverer start
 
 if param compare -s ICE_EN 1
 then

ROMFS/px4fmu_common/init.d/rc.mc_apps

@@ -36,3 +36,8 @@ mc_pos_control start
 # Start Multicopter Land Detector.
 #
 land_detector start multicopter
+
+if param compare -s MC_NN_EN 1
+then
+	mc_nn_control start
+fi

ROMFS/px4fmu_common/init.d/rcS

@@ -568,11 +568,7 @@ else
 		px4flow start -X &
 	fi
 
-	# Payload deliverer module if gripper is enabled
-	if param compare -s PD_GRIPPER_EN 1
-	then
-		payload_deliverer start
-	fi
+	payload_deliverer start
 
 	if param compare -s ICE_EN 1
 	then

Tools/astyle/files_to_check_code_style.sh

@@ -37,4 +37,5 @@ exec find boards msg src platforms test \
     -path src/modules/zenoh/zenoh-pico -prune -o \
     -path boards/modalai/voxl2/libfc-sensor-api -prune -o \
     -path src/drivers/actuators/vertiq_io/iq-module-communication-cpp -prune -o \
+    -path src/lib/tensorflow_lite_micro/tflite_micro -prune -o \
     \( -type f \( -name "*.c" -o -name "*.h" -o -name "*.cpp" -o -name "*.hpp" \) -print \) | grep $PATTERN

Tools/run-clang-tidy.py

@@ -110,10 +110,11 @@ def run_tidy(args, tmpdir, build_path, queue):
                                      args.extra_arg, args.extra_arg_before)
 
     try:
-      subprocess.check_call(invocation, stdin=None, stdout=open(os.devnull, 'wb'), stderr=subprocess.STDOUT)
+      subprocess.check_call(invocation, stdin=None, stdout=open(os.devnull, 'w'), stderr=open(os.devnull, 'w'))
     except subprocess.CalledProcessError as e:
-      sys.stdout.write(' '.join(invocation) + '\n')
-      subprocess.call(invocation)
+      sys.stdout.write(f'failed on {name} --> {" ".join(invocation)}\n')
+      # Now run again to see the actual output
+      subprocess.call(invocation, stdin=None)
       global tidy_failures
       tidy_failures = tidy_failures + 1
 

boards/ark/fmu-v6x/default.px4board

@@ -79,6 +79,7 @@ CONFIG_MODULES_MC_POS_CONTROL=y
 CONFIG_MODULES_MC_RATE_CONTROL=y
 CONFIG_MODULES_NAVIGATOR=y
 CONFIG_NUM_MISSION_ITMES_SUPPORTED=1000
+CONFIG_MODULES_PAYLOAD_DELIVERER=y
 CONFIG_MODULES_RC_UPDATE=y
 CONFIG_MODULES_SENSORS=y
 CONFIG_MODULES_UXRCE_DDS_CLIENT=y