Merged
Conversation
|
This PR was identified as stale and it will be closed in 30 days unless any activity is detected. |
Contributor
Author
|
For some reason the previous build had a failure that didn't seem related. This should still be a valid fix and not stale. |
Contributor
Author
|
The SITL errors are unrelated to the change. |
dakejahl
approved these changes
Jan 13, 2026
TheLukaDragar
pushed a commit
to TheLukaDragar/PX4-Autopilot
that referenced
this pull request
Feb 24, 2026
Co-authored-by: jmackay2 <jmackay2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
The matrix
test_data.pyscript did not work.Solution
std::sqrtand replace with a python sqrt (**0.5)Alternatives
We could use a python package that does
sqrtif we want to be more verbose, but the square function just before is just using python square, so it is probably not necessary.Test coverage
test_data.pyscript successfully with the outputs printing correctly