Skip to content

Fix the test data matrix script#24745

Merged
dakejahl merged 2 commits intoPX4:mainfrom
jmackay2:test_data_fix
Jan 13, 2026
Merged

Fix the test data matrix script#24745
dakejahl merged 2 commits intoPX4:mainfrom
jmackay2:test_data_fix

Conversation

@jmackay2
Copy link
Copy Markdown
Contributor

Solved Problem

The matrix test_data.py script did not work.

Solution

  • Add python3 shebang
  • Remove std::sqrt and replace with a python sqrt (**0.5)
  • Add a float epsilon

Alternatives

We could use a python package that does sqrt if we want to be more verbose, but the square function just before is just using python square, so it is probably not necessary.

Test coverage

  • Ran the test_data.py script successfully with the outputs printing correctly

@github-actions github-actions bot added the stale label May 22, 2025
@mrpollo mrpollo removed the stale label Sep 12, 2025
@github-actions
Copy link
Copy Markdown

This PR was identified as stale and it will be closed in 30 days unless any activity is detected.

@github-actions github-actions bot added the stale label Dec 14, 2025
@jmackay2
Copy link
Copy Markdown
Contributor Author

For some reason the previous build had a failure that didn't seem related. This should still be a valid fix and not stale.

@jmackay2
Copy link
Copy Markdown
Contributor Author

The SITL errors are unrelated to the change.

@dakejahl dakejahl merged commit e371c4e into PX4:main Jan 13, 2026
66 of 68 checks passed
TheLukaDragar pushed a commit to TheLukaDragar/PX4-Autopilot that referenced this pull request Feb 24, 2026
Co-authored-by: jmackay2 <jmackay2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants