Skip to content

[EKF2] Run simplified GNSS checks after initial fix #24909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaEtUgR merged 1 commit into from
Jun 6, 2025
Merged

[EKF2] Run simplified GNSS checks after initial fix #24909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion src/modules/ekf2/EKF/aid_sources/gnss/gnss_checks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ bool GnssChecks::run(const gnssSample &gnss, uint64_t time_us)
bool passed = false;

if (_initial_checks_passed) {
if (runInitialFixChecks(gnss)) {
if (runSimplifiedChecks(gnss)) {
_time_last_pass_us = time_us;
passed = isTimedOut(_time_last_fail_us, time_us, math::max((uint64_t)1e6, (uint64_t)_params.min_health_time_us / 10));

Expand Down Expand Up @@ -79,6 +79,34 @@ bool GnssChecks::run(const gnssSample &gnss, uint64_t time_us)
return passed;
}

bool GnssChecks::runSimplifiedChecks(const gnssSample &gnss)
{
_check_fail_status.flags.fix = (gnss.fix_type < 3);

// Check the reported horizontal and vertical position accuracy
_check_fail_status.flags.hacc = (gnss.hacc > 50.f);
_check_fail_status.flags.vacc = (gnss.vacc > 50.f);

// Check the reported speed accuracy
_check_fail_status.flags.sacc = (gnss.sacc > 10.f);

_check_fail_status.flags.spoofed = gnss.spoofed;

bool passed = true;

if (
_check_fail_status.flags.fix ||
(_check_fail_status.flags.hacc && isCheckEnabled(GnssChecksMask::kHacc)) ||
(_check_fail_status.flags.vacc && isCheckEnabled(GnssChecksMask::kVacc)) ||
(_check_fail_status.flags.sacc && isCheckEnabled(GnssChecksMask::kSacc)) ||
(_check_fail_status.flags.spoofed && isCheckEnabled(GnssChecksMask::kSpoofed))
) {
passed = false;
}

return passed;
}

bool GnssChecks::runInitialFixChecks(const gnssSample &gnss)
{
// Check the fix type
Expand Down
1 change: 1 addition & 0 deletions src/modules/ekf2/EKF/aid_sources/gnss/gnss_checks.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ class GnssChecks final

bool isCheckEnabled(GnssChecksMask check) { return (_params.check_mask & static_cast<int32_t>(check)); }

bool runSimplifiedChecks(const gnssSample &gnss);
bool runInitialFixChecks(const gnssSample &gnss);
void runOnGroundGnssChecks(const gnssSample &gnss);

Expand Down
11 changes: 9 additions & 2 deletions src/modules/ekf2/test/test_EKF_gps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,19 @@ TEST_F(EkfGpsTest, gpsTimeout)
// WHEN: the number of satellites drops below the minimum
_sensor_simulator._gps.setNumberOfSatellites(3);

// THEN: the GNSS fusion does not stop because other metrics are good enough
_sensor_simulator.runSeconds(8);
EXPECT_TRUE(_ekf_wrapper.isIntendingGpsFusion());

// WHEN: the fix type drops
_sensor_simulator._gps.setFixType(0);

// THEN: the GNSS fusion stops after some time
_sensor_simulator.runSeconds(8);
EXPECT_FALSE(_ekf_wrapper.isIntendingGpsFusion());

// BUT WHEN: the number of satellites is good again
_sensor_simulator._gps.setNumberOfSatellites(16);
// BUT WHEN: the fix type is good again
_sensor_simulator._gps.setFixType(3);

// THEN: the GNSS fusion restarts
_sensor_simulator.runSeconds(6);
Expand Down
Loading