Open
Conversation
MaEtUgR
previously approved these changes
Dec 9, 2025
Member
MaEtUgR
left a comment
MaEtUgR
left a comment
There was a problem hiding this comment.
Nice! Thanks for adding the test 👍
Claudio-Chies
force-pushed
the
pr-battery_unhealthy
branch
2 times, most recently
from
6c48055 to
24a3fa9
Compare
Claudio-Chies
force-pushed
the
pr-battery_unhealthy
branch
from
24a3fa9 to
c0f2846
Compare
Co-authored-by: Matthias Grob <maetugr@gmail.com>
MaEtUgR
force-pushed
the
pr-battery_unhealthy
branch
from
c0f2846 to
5d0faf4
Compare
MaEtUgR
reviewed
Feb 23, 2026
| public: | ||
| Failsafe(ModuleParams *parent) : FailsafeBase(parent) {} | ||
|
|
||
| void updateArmingState(const hrt_abstime &time_us, bool armed, const failsafe_flags_s &status_flags); |
Member
There was a problem hiding this comment.
This should stay protected right? 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution
Adds unit test to thest the failsafe for unhealty batteries during the spoolup phase
Test coverage