Skip to content

Add Wheel and Gimbal support to PWM center#26211

Merged
ttechnick merged 3 commits intoPX4:mainfrom
ttechnick:pr-servo-center-gimbal
Jan 6, 2026
Merged

Add Wheel and Gimbal support to PWM center#26211
ttechnick merged 3 commits intoPX4:mainfrom
ttechnick:pr-servo-center-gimbal

Conversation

@ttechnick
Copy link
Copy Markdown
Member

Solved Problem

Fixes #26210: Add Wheel and Gimbal to have PWM Servo Center functionality.

Changelog Entry

For release notes:

Bugfix: Include Wheel and Gimbal for PWM Center

@ttechnick ttechnick marked this pull request as ready for review January 5, 2026 09:39
@perrrre perrrre requested review from perrrre and sfuhrer January 5, 2026 10:15
Copy link
Copy Markdown
Contributor

@perrrre perrrre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will remove the gimbal output functions from my PR then. Do we need to update documentation?

@ttechnick
Copy link
Copy Markdown
Member Author

Thank, I will remove the gimbal output functions from my PR then. Do we need to update documentation?

We could add a list of the functions this applies to, but that may not be necessary. The behavior should be self-explanatory, since the feature is intended to apply to all PWM servos that can reasonably be expected to have a center position.

sfuhrer
sfuhrer previously approved these changes Jan 5, 2026
Copy link
Copy Markdown
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extension.
About documentation: Would be good to add it to gimbal configuration docs, not sure what we already have there though. Or we remove the PWM_CENT docs from the control surface section and keep them separated, noting that it effects all actuators with a clearly defined "center".

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2026

No flaws found

@ttechnick ttechnick enabled auto-merge (squash) January 6, 2026 17:00
@ttechnick ttechnick merged commit 38b6a9a into PX4:main Jan 6, 2026
69 checks passed
@ttechnick ttechnick deleted the pr-servo-center-gimbal branch January 6, 2026 17:13
@hamishwillee
Copy link
Copy Markdown
Contributor

@ttechnick As per #26211 (review) - have you a plan for the docs?

Everything about setting up the Gimbal specifically for PX4 is in https://docs.px4.io/main/en/advanced/gimbal_control#gimbal-on-fc-pwm-output-mnt-mode-out-aux .

If you create a PR then please assign @julianoes to check it. If you need more help, ping Julian or me. (Julian wrote that implementation and also was an author of the MAVLink Gimbal protocol)

@ttechnick
Copy link
Copy Markdown
Member Author

@hamishwillee The PR already includes the update to the gimbal documentation in Gimbal docs . This was added after that review comment from Silvan.

If you feel like it is not enough, please elaborate what exactly is not clear and I will fix it.

@hamishwillee
Copy link
Copy Markdown
Contributor

@ttechnick I didn't check before posting so it is probably perfect. Will comment tomorrow if there is anything to be done.

@hamishwillee
Copy link
Copy Markdown
Contributor

It's good. Thanks.

ttechnick added a commit that referenced this pull request Jan 21, 2026
* Add Wheel and Gimbal support to PWM center

* Document Center feature for PWM Gimbal
sfuhrer pushed a commit that referenced this pull request Jan 22, 2026
* Add Wheel and Gimbal support to PWM center

* Document Center feature for PWM Gimbal
mbjd pushed a commit that referenced this pull request Feb 17, 2026
* Add Wheel and Gimbal support to PWM center

* Document Center feature for PWM Gimbal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Servo center Feature only works for Servos

4 participants