FixedWingLandDetector: force to landed during runway takeoff#26252
Merged
mahima-yoga merged 2 commits intomainfrom Jan 14, 2026
Merged
FixedWingLandDetector: force to landed during runway takeoff#26252mahima-yoga merged 2 commits intomainfrom
mahima-yoga merged 2 commits intomainfrom
Conversation
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 112 byte (0.01 %)]px4_fmu-v6x [Total VM Diff: 112 byte (0.01 %)]Updated: 2026-01-14T15:40:14 |
sfuhrer
previously approved these changes
Jan 12, 2026
1ec6bee to
bd6bd46
Compare
Contributor
Author
|
Thanks @sfuhrer! I added your suggestions, once approved I will clean up the commits |
sfuhrer
approved these changes
Jan 14, 2026
bd6bd46 to
8a17d8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
Takeoff detection occurs when the vehicle is
!_landed. During a runway takeoff, it's possible that one of the conditions to be landed is no longer met and premature takeoff is detected. This unlocks the integrator and can start introducing unwanted control surface deflections.Solution
As we do with hand/catapult launch detection, we can use the knowledge that we are in an auto-takeoff mode inside the land detector. This PR:
runway_takeoff_stateto theFixedWingRunwayControl.msgfixed_wing_runway_control_s::STATE_FLYtofixed_wing_runway_control_s::STATE_FLYING. I think it's nicer and then it's the same as the launch detection state.runway_takeoff_state < fixed_wing_runway_control_s::STATE_CLIMBOUTChangelog Entry
For release notes:
Test coverage
Flight Test
With
LNDFW_AIRSPD_MAX=6andLNDFW_VEL_XY_MAX=5. We stay landed until the climbout phase.SITL Tests:
runway_takeoff_statetoCLAMPED_TO_RUNWAYin code (log):