msg_docs: fix IndexError crash in generate_msg_docs.py#26546
Merged
Pedro-Roque merged 1 commit intomainfrom Feb 21, 2026
Merged
msg_docs: fix IndexError crash in generate_msg_docs.py#26546Pedro-Roque merged 1 commit intomainfrom
Pedro-Roque merged 1 commit intomainfrom
Conversation
Fix generate_msg_docs.py IndexError when a .msg file declares a single topic that does not match the camel_to_snake default (e.g. AuxGlobalPosition.msg). The error message referenced self.topics[1] (out of bounds) instead of self.topics[0]. Fix camel_to_snake() regex to correctly convert names like "AuxGlobalPosition" to "aux_global_position". The previous regex produced "aux_globalposition" because it failed to insert an underscore between a lowercase letter and an uppercase letter mid-word. Also remove stderr redirection (2>&1) from all make targets in metadata_sync.sh so that errors are visible in CI logs even in non-verbose mode, making failures easier to diagnose. Signed-off-by: Ramon Roche <mrpollo@gmail.com>
Pedro-Roque
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Docs - Orchestrator CI job failing on every branch since Feb 20.
generate_msg_docs.pycrashes with anIndexErrorwhen a.msgfile declares a single topic that doesn't match thecamel_to_snakedefault. Thecamel_to_snake()regex was also broken for compound CamelCase names (AuxGlobalPositionproducedaux_globalpositioninstead ofaux_global_position). Additionally,metadata_sync.shwas redirecting stderr to/dev/nullin non-verbose mode, hiding the actual error from CI logs.PR #26306 added
AuxGlobalPosition.msg, which exposed two latent bugs ingenerate_msg_docs.pyfrom PR #24977.Failed runs: