refactor(battery_simulator): clean up param SIM_BAT_ENABLE

[mbjd]

Solved Problem

The param SIM_BAT_ENABLE provides very niche functionality (no battery sim at all).

Solution

Remove it. Instead, disable the battery sim completely by setting SIM_BAT_DRAIN <= 0.

Also, add protection against division by 0 - in case somebody does run the battery sim but at runtime sets SIM_BAT_DRAIN=0.

Docs, param description, and lower limit updated accordingly.

Changelog Entry

Battery simulator: Remove parameter SIM_BAT_ENABLE. Disable battery simulator with SIM_BAT_DRAIN <= 0.

[github-actions]

No broken links found in changed files.

[mbjd]

Rebased on main (146f2b2)

[dakejahl]

CI failures are unrelated

[dakejahl]

this isn't correct since the source code is constraining it to a max of 1

[mbjd]

The min of 0 is needed to turn it off when 0, so the code does not run in that case.

But the constraining in the first place is not needed anymore since we changed from disable on -1 to disable on 0, so I removed it. 6380c4f (we are safe from division by zero as param compare has a tolerance of 1e-7)

[dakejahl]

I was referring to the max value, but I was confused about what this parameter does. We should indeed add the clamp in source so avoid a divide by zero.

[mbjd]

Ah okay, sorry for the persistent misunderstandings!

• I think we can get rid of the max entirely actually, no reason to limit it at an arbitrary value.
• Added back the constraining to a min of 1 (you're right there are still cases where it is beneficial: starting the module and then changing the param to 0...)
• Commited your rewordings, thanks!

[github-actions]

No broken links found in changed files.

[dakejahl]

I was referring to the max value, but I was confused about what this parameter does. We should indeed add the clamp in source so avoid a divide by zero.