Skip to content

feat(boards/saam_saampixv1_1): add board support for saampixv1_1#26902

Open
ashwanisihag wants to merge 9 commits intoPX4:mainfrom
ashwanisihag:saam_saampixv1_1_pr
Open

feat(boards/saam_saampixv1_1): add board support for saampixv1_1#26902
ashwanisihag wants to merge 9 commits intoPX4:mainfrom
ashwanisihag:saam_saampixv1_1_pr

Conversation

@ashwanisihag
Copy link
Copy Markdown

@ashwanisihag ashwanisihag commented Mar 29, 2026

Summary

Add initial PX4 board support for saampixv1_1.

What this PR adds

  • New board target under boards/saam/saampixv1_1
  • Board metadata in default.px4board
  • Firmware metadata in firmware.prototype
  • Board init scripts
  • NuttX board configuration
  • Board source files for init, SPI, I2C, CAN, USB, LED, and timer setup

Build target

  • saam_saampixv1_1_default

Notes

Validation

  • Local target build completed for saam_saampixv1_1_default
  • CI results will be used to catch any integration issues

Follow-up

  • Additional documentation and board-specific tuning/default parameters can be added in follow-up PRs if required.

@ashwanisihag ashwanisihag changed the title boards: add saampixv1_1 target for firmware release feat(boards/saam_saampixv1_1): add board support for saampixv1_1 Mar 29, 2026
@ashwanisihag
Copy link
Copy Markdown
Author

@dagar CI is green now. This PR adds initial SaamPix v1.1 board support and is ready for review when you have time.

Copy link
Copy Markdown
Member

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Inline change.

For All PX4 (C) files. Update the date as a range 2020-2026
Fix all references to the board you copied from and ensure the code and comments match your HW.

Ashwani Sihag added 3 commits March 31, 2026 13:16
- Replace all MINDPX/MINDPXv2/PX4FMU board references with SaamPixV1_1
- Update Airmind Development Team to Saam Drones Development Team in copyright headers
- Update PX4 copyright year range to 2020-2026 on all C/C++ files
- Rename bootloader binary to match board version (v1_1)
- Remove untracked backup files
@ashwanisihag
Copy link
Copy Markdown
Author

ashwanisihag commented Mar 31, 2026

@davids5 All requested changes have been addressed across 3 commits:

✅ Copyright years updated to 2020-2026 in all board files
✅ All board name/HW references corrected to SaamPixV1_1 (no MINDPX references remain)
✅ USB vendor string corrected to "PX4" (was incorrectly set to "Saam Drones")
✅ USB product ID changed from 0x0030 (collision with MindPX-v2, the board used as template) to unique 0x008E
✅ Fixed stale file path comment in board.h (configs/px4fmu → boards/saam/saampixv1_1)

Ready for re-review.

@ashwanisihag
Copy link
Copy Markdown
Author

@davids5 Final follow-up done for board identity consistency:\n\n- Updated bundled bootloader artifact at boards/saam/saampixv1_1/extras/saam_saampixv1_1_bootloader.bin\n- Replaced stale image that still carried MindPX identity with the SaamPix v1.1 bootloader artifact\n- Pushed in commit 19ddf18 on branch saam_saampixv1_1_pr\n\nAll board names and hardware-facing identity strings in this board support package should now match SaamPixV1_1 HW. Requesting re-review.

Copy link
Copy Markdown
Member

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clear up the USB VID,PID and Vender ID string with Dronecode @mrpollo
Please fix copyright notices for non orignal work.
Remove platforms/nuttx/src/px4/stm/stm32_common/include/px4_arch/io_timer.h from your PR.

@ashwanisihag Why are you changing file in boards/airmind/mindpx-v2 in this PR?

@ashwanisihag
Copy link
Copy Markdown
Author

ashwanisihag commented Apr 2, 2026

@davids5 Addressed the latest review feedback in commit 9293ea3ba7.

  1. Removed unrelated changes from this PR:
  • platforms/nuttx/src/px4/stm/stm32_common/include/px4_arch/io_timer.h
  • boards/airmind/mindpx-v2/default.px4board
  • boards/airmind/mindpx-v2/init/rc.board_sensors
  • boards/airmind/mindpx-v2/src/spi.cpp
  1. Updated copied-file copyright attribution to PX4 in:
  • boards/saam/saampixv1_1/src/can.c
  • boards/saam/saampixv1_1/src/led.c
  • boards/saam/saampixv1_1/src/usb.c

For USB VID/PID + vendor string policy:
@mrpollo could you please confirm the expected VID/PID + vendor string assignment path for this external vendor board so I can align defconfig exactly with project policy?

Requesting re-review.

@ashwanisihag
Copy link
Copy Markdown
Author

Follow-up fix pushed: updated USB vendor string for saampixv1_1 from "PX4" to "Saam Drones" in boards/saam/saampixv1_1/nuttx-config/nsh/defconfig.

Current values are now:

  • VENDORSTR="Saam Drones"
  • VENDORID=0x26ac
  • PRODUCTID=0x008E

@mrpollo please confirm whether VID/PID should remain as above or be changed to a Dronecode-assigned pair for this vendor board.

@ashwanisihag
Copy link
Copy Markdown
Author

@davids5 quick follow-up: all requested fixes are in, all review threads are resolved, and CI checks are green.

Could you please take another look when you have a moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants