feat(boards/saam_saampixv1_1): add board support for saampixv1_1#26902
feat(boards/saam_saampixv1_1): add board support for saampixv1_1#26902ashwanisihag wants to merge 9 commits intoPX4:mainfrom
Conversation
|
@dagar CI is green now. This PR adds initial SaamPix v1.1 board support and is ready for review when you have time. |
davids5
left a comment
There was a problem hiding this comment.
See Inline change.
For All PX4 (C) files. Update the date as a range 2020-2026
Fix all references to the board you copied from and ensure the code and comments match your HW.
- Replace all MINDPX/MINDPXv2/PX4FMU board references with SaamPixV1_1 - Update Airmind Development Team to Saam Drones Development Team in copyright headers - Update PX4 copyright year range to 2020-2026 on all C/C++ files - Rename bootloader binary to match board version (v1_1) - Remove untracked backup files
|
@davids5 All requested changes have been addressed across 3 commits: ✅ Copyright years updated to 2020-2026 in all board files Ready for re-review. |
|
@davids5 Final follow-up done for board identity consistency:\n\n- Updated bundled bootloader artifact at boards/saam/saampixv1_1/extras/saam_saampixv1_1_bootloader.bin\n- Replaced stale image that still carried MindPX identity with the SaamPix v1.1 bootloader artifact\n- Pushed in commit 19ddf18 on branch saam_saampixv1_1_pr\n\nAll board names and hardware-facing identity strings in this board support package should now match SaamPixV1_1 HW. Requesting re-review. |
There was a problem hiding this comment.
Please clear up the USB VID,PID and Vender ID string with Dronecode @mrpollo
Please fix copyright notices for non orignal work.
Remove platforms/nuttx/src/px4/stm/stm32_common/include/px4_arch/io_timer.h from your PR.
@ashwanisihag Why are you changing file in boards/airmind/mindpx-v2 in this PR?
platforms/nuttx/src/px4/stm/stm32_common/include/px4_arch/io_timer.h
Outdated
Show resolved
Hide resolved
|
@davids5 Addressed the latest review feedback in commit
For USB VID/PID + vendor string policy: Requesting re-review. |
|
Follow-up fix pushed: updated USB vendor string for saampixv1_1 from "PX4" to "Saam Drones" in boards/saam/saampixv1_1/nuttx-config/nsh/defconfig. Current values are now:
@mrpollo please confirm whether VID/PID should remain as above or be changed to a Dronecode-assigned pair for this vendor board. |
|
@davids5 quick follow-up: all requested fixes are in, all review threads are resolved, and CI checks are green. Could you please take another look when you have a moment? |
Summary
Add initial PX4 board support for
saampixv1_1.What this PR adds
boards/saam/saampixv1_1default.px4boardfirmware.prototypeBuild target
saam_saampixv1_1_defaultNotes
Validation
saam_saampixv1_1_defaultFollow-up