revert(mavlink): Revert mavlink signing support (#25284) by ttechnick · Pull Request #26915 · PX4/PX4-Autopilot

ttechnick · 2026-03-31T14:23:44Z

Solved Problem

Main currently does not work properly, due to faulty mavlink signing that cannot be disabled. This poses a large problem for development on Main.

Solution

Revert the problematic mavlink signing, until a proper solution is found (see this PR).

This reverts commit 358574f.

Changelog Entry

For release notes:

Bugfix: revert mavlink signing.

Details

See the issue description #26893 .

This reverts commit 358574f.

github-actions · 2026-03-31T14:25:09Z

💡 Commit messages could be improved

Not blocking, but these commit messages could use some cleanup.

Commit	Message	Suggestion
`70d0ecfb8f`	Revert "feat(mavlink): mavlink signing support (#25284)"	Missing conventional commit format (e.g. "feat(ekf2): add something")

See the commit message convention for details.

This comment will be automatically removed once the issues are resolved.

github-actions · 2026-03-31T14:32:38Z

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: -1136 byte (-0.05 %)]

    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +57  [ = ]       0    .debug_abbrev
-0.0%     -80  [ = ]       0    .debug_aranges
-0.1%    -320  [ = ]       0    .debug_frame
-0.0% -3.91Ki  [ = ]       0    .debug_info
-0.0% -1.28Ki  [ = ]       0    .debug_line
  [DEL]      -6  [ = ]       0    [Unmapped]
  -0.0% -1.28Ki  [ = ]       0    [section .debug_line]
-0.0% -1.45Ki  [ = ]       0    .debug_loclists
-0.0%    -143  [ = ]       0    .debug_rnglists
 -33.3%      -1  [ = ]       0    [Unmapped]
  -0.0%    -142  [ = ]       0    [section .debug_rnglists]
-0.0% -1.76Ki  [ = ]       0    .debug_str
-0.1%    -540  [ = ]       0    .strtab
  [NEW]     +12  [ = ]       0    CSWTCH.1957
  [DEL]     -12  [ = ]       0    CSWTCH.1970
  [NEW]     +12  [ = ]       0    CSWTCH.2742
  [DEL]     -12  [ = ]       0    CSWTCH.2764
  [NEW]     +24  [ = ]       0    CSWTCH.3501
  [NEW]     +24  [ = ]       0    CSWTCH.3502
  [DEL]     -24  [ = ]       0    CSWTCH.3529
  [DEL]     -24  [ = ]       0    CSWTCH.3530
  [DEL]     -58  [ = ]       0    Mavlink::get_instance_for_status()
  [DEL]     -56  [ = ]       0    MavlinkSignControl::MavlinkSignControl()
  [DEL]     -45  [ = ]       0    MavlinkSignControl::accept_unsigned()
  [DEL]     -65  [ = ]       0    MavlinkSignControl::check_for_signing()
  [DEL]     -48  [ = ]       0    MavlinkSignControl::is_array_all_zeros()
  [DEL]     -61  [ = ]       0    MavlinkSignControl::start()
  [DEL]     -51  [ = ]       0    MavlinkSignControl::write_key_and_timestamp()
 -26.7%     -16  [ = ]       0    ___ZL19param_get_cplusplustPf.isra.0_veneer
   +67%     +16  [ = ]       0    __hrt_call_enter_veneer
  [DEL]     -51  [ = ]       0    accept_unsigned_callback()
  [DEL]     -36  [ = ]       0    global_mavlink_signing_streams
  [DEL]     -69  [ = ]       0    mavlink_msg_setup_signing_decode
-0.1%    -432  [ = ]       0    .symtab
  [NEW]     +32  [ = ]       0    CSWTCH.1957
  [DEL]     -32  [ = ]       0    CSWTCH.1970
  [NEW]     +32  [ = ]       0    CSWTCH.2742
  [DEL]     -32  [ = ]       0    CSWTCH.2764
  [NEW]     +48  [ = ]       0    CSWTCH.3501
  [NEW]     +48  [ = ]       0    CSWTCH.3502
  [DEL]     -48  [ = ]       0    CSWTCH.3529
  [DEL]     -48  [ = ]       0    CSWTCH.3530
 -33.3%     -32  [ = ]       0    Mavlink::Mavlink()
  [DEL]     -48  [ = ]       0    Mavlink::get_instance_for_status()
   +50%     +16  [ = ]       0    Mavlink::request_stop()
 -66.7%     -32  [ = ]       0    MavlinkReceiver::handle_message_logging_ack()
 -50.0%     -16  [ = ]       0    MavlinkReceiver::stop()
  [DEL]     -32  [ = ]       0    MavlinkSignControl::MavlinkSignControl()
  [DEL]     -32  [ = ]       0    MavlinkSignControl::accept_unsigned()
  [DEL]     -32  [ = ]       0    MavlinkSignControl::check_for_signing()
  [DEL]     -32  [ = ]       0    MavlinkSignControl::is_array_all_zeros()
  [DEL]     -48  [ = ]       0    MavlinkSignControl::start()
  [DEL]     -48  [ = ]       0    MavlinkSignControl::write_key_and_timestamp()
  +100%     +16  [ = ]       0    MavlinkStreamAutopilotStateForGimbalDevice::send()
 -117.9%    -112  [ = ]       0    [9 Others]
+9.5%    +944  [ = ]       0    [Unmapped]
[ = ]       0  -0.2%    -192    .bss
  [ = ]       0 -50.0%      -4    Mavlink::_boot_complete
  [ = ]       0 -66.7%      -8    _bdshot_channel_mask
  [ = ]       0 -53.3%     -32    [section .bss]
  [ = ]       0  [DEL]    -148    global_mavlink_signing_streams
-0.0%    -944  -0.0%    -944    .text
  [NEW]     +60  [NEW]     +60    CSWTCH.1957
  [NEW]     +44  [NEW]     +44    CSWTCH.2742
   +22%     +28   +22%     +28    MavlinkReceiver::handle_message_generator_status()
  [NEW]     +14  [NEW]     +14    CSWTCH.3501
  [NEW]     +14  [NEW]     +14    CSWTCH.3502
  [DEL]     -18  [DEL]     -18    MavlinkSignControl::MavlinkSignControl()
  [DEL]     -22  [DEL]     -22    MavlinkSignControl::is_array_all_zeros()
  -0.9%     -24  -0.9%     -24    Mavlink::task_main()
 -36.8%     -28 -36.8%     -28    Mavlink::handle_message()
  [DEL]     -32  [DEL]     -32    MavlinkSignControl::accept_unsigned()
  [DEL]     -34  [DEL]     -34    accept_unsigned_callback()
  -3.4%     -36  -3.4%     -36    Mavlink::Mavlink()
  [DEL]     -40  [DEL]     -40    mavlink_msg_setup_signing_decode
  [DEL]     -44  [DEL]     -44    CSWTCH.2764
 -107.6%     -58 -107.6%     -58    [9 Others]
  [DEL]     -60  [DEL]     -60    CSWTCH.1970
  [DEL]     -64  [DEL]     -64    Mavlink::get_instance_for_status()
  [DEL]    -104  [DEL]    -104    MavlinkSignControl::write_key_and_timestamp()
  [DEL]    -108  [DEL]    -108    MavlinkSignControl::check_for_signing()
  -0.1%    -200  -0.1%    -200    [section .text]
  [DEL]    -232  [DEL]    -232    MavlinkSignControl::start()
-0.0% -9.83Ki  -0.1% -1.11Ki    TOTAL

px4_fmu-v6x [Total VM Diff: -1128 byte (-0.06 %)]

    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +57  [ = ]       0    .debug_abbrev
-0.0%     -80  [ = ]       0    .debug_aranges
-0.1%    -320  [ = ]       0    .debug_frame
-0.0% -3.91Ki  [ = ]       0    .debug_info
-0.0% -1.27Ki  [ = ]       0    .debug_line
   +50%      +2  [ = ]       0    [Unmapped]
  -0.0% -1.28Ki  [ = ]       0    [section .debug_line]
-0.0% -1.46Ki  [ = ]       0    .debug_loclists
-0.0%    -144  [ = ]       0    .debug_rnglists
  [DEL]      -2  [ = ]       0    [Unmapped]
  -0.0%    -142  [ = ]       0    [section .debug_rnglists]
-0.1% -1.75Ki  [ = ]       0    .debug_str
-0.1%    -540  [ = ]       0    .strtab
  [NEW]     +12  [ = ]       0    CSWTCH.1957
  [DEL]     -12  [ = ]       0    CSWTCH.1970
  [NEW]     +12  [ = ]       0    CSWTCH.2742
  [DEL]     -12  [ = ]       0    CSWTCH.2764
  [NEW]     +24  [ = ]       0    CSWTCH.3501
  [NEW]     +24  [ = ]       0    CSWTCH.3502
  [DEL]     -24  [ = ]       0    CSWTCH.3529
  [DEL]     -24  [ = ]       0    CSWTCH.3530
  [DEL]     -58  [ = ]       0    Mavlink::get_instance_for_status()
  [DEL]     -56  [ = ]       0    MavlinkSignControl::MavlinkSignControl()
  [DEL]     -45  [ = ]       0    MavlinkSignControl::accept_unsigned()
  [DEL]     -65  [ = ]       0    MavlinkSignControl::check_for_signing()
  [DEL]     -48  [ = ]       0    MavlinkSignControl::is_array_all_zeros()
  [DEL]     -61  [ = ]       0    MavlinkSignControl::start()
  [DEL]     -51  [ = ]       0    MavlinkSignControl::write_key_and_timestamp()
  [DEL]     -51  [ = ]       0    accept_unsigned_callback()
  [DEL]     -36  [ = ]       0    global_mavlink_signing_streams
  [DEL]     -69  [ = ]       0    mavlink_msg_setup_signing_decode
-0.1%    -432  [ = ]       0    .symtab
  [NEW]     +32  [ = ]       0    CSWTCH.1957
  [DEL]     -32  [ = ]       0    CSWTCH.1970
  [NEW]     +32  [ = ]       0    CSWTCH.2742
  [DEL]     -32  [ = ]       0    CSWTCH.2764
  [NEW]     +48  [ = ]       0    CSWTCH.3501
  [NEW]     +48  [ = ]       0    CSWTCH.3502
  [DEL]     -48  [ = ]       0    CSWTCH.3529
  [DEL]     -48  [ = ]       0    CSWTCH.3530
 -33.3%     -32  [ = ]       0    Mavlink::Mavlink()
  [DEL]     -48  [ = ]       0    Mavlink::get_instance_for_status()
   +50%     +16  [ = ]       0    Mavlink::request_stop()
 -66.7%     -32  [ = ]       0    MavlinkReceiver::handle_message_logging_ack()
 -50.0%     -16  [ = ]       0    MavlinkReceiver::stop()
  [DEL]     -32  [ = ]       0    MavlinkSignControl::MavlinkSignControl()
  [DEL]     -32  [ = ]       0    MavlinkSignControl::accept_unsigned()
  [DEL]     -32  [ = ]       0    MavlinkSignControl::check_for_signing()
  [DEL]     -32  [ = ]       0    MavlinkSignControl::is_array_all_zeros()
  [DEL]     -48  [ = ]       0    MavlinkSignControl::start()
  [DEL]     -48  [ = ]       0    MavlinkSignControl::write_key_and_timestamp()
  +100%     +16  [ = ]       0    MavlinkStreamAutopilotStateForGimbalDevice::send()
 -150.0%    -112  [ = ]       0    [5 Others]
 +21%    +936  [ = ]       0    [Unmapped]
[ = ]       0  -0.2%    -192    .bss
  [ = ]       0  +100%      +4    g_dma_perf
  [ = ]       0 -50.0%      -4    Mavlink::_boot_complete
  [ = ]       0 -66.7%      -8    _bdshot_channel_mask
  [ = ]       0 -64.3%     -36    [section .bss]
  [ = ]       0  [DEL]    -148    global_mavlink_signing_streams
-0.0%    -936  -0.0%    -936    .text
  [NEW]     +60  [NEW]     +60    CSWTCH.1957
  [NEW]     +44  [NEW]     +44    CSWTCH.2742
   +22%     +28   +22%     +28    MavlinkReceiver::handle_message_generator_status()
  [NEW]     +14  [NEW]     +14    CSWTCH.3501
  [NEW]     +14  [NEW]     +14    CSWTCH.3502
  [DEL]     -18  [DEL]     -18    MavlinkSignControl::MavlinkSignControl()
  [DEL]     -22  [DEL]     -22    MavlinkSignControl::is_array_all_zeros()
  -0.9%     -24  -0.9%     -24    Mavlink::task_main()
 -36.8%     -28 -36.8%     -28    Mavlink::handle_message()
  [DEL]     -32  [DEL]     -32    MavlinkSignControl::accept_unsigned()
  [DEL]     -34  [DEL]     -34    accept_unsigned_callback()
  -3.4%     -36  -3.4%     -36    Mavlink::Mavlink()
  [DEL]     -40  [DEL]     -40    mavlink_msg_setup_signing_decode
  [DEL]     -44  [DEL]     -44    CSWTCH.2764
 -106.1%     -50 -106.1%     -50    [9 Others]
  [DEL]     -60  [DEL]     -60    CSWTCH.1970
  [DEL]     -64  [DEL]     -64    Mavlink::get_instance_for_status()
  [DEL]    -104  [DEL]    -104    MavlinkSignControl::write_key_and_timestamp()
  [DEL]    -108  [DEL]    -108    MavlinkSignControl::check_for_signing()
  -0.1%    -200  -0.1%    -200    [section .text]
  [DEL]    -232  [DEL]    -232    MavlinkSignControl::start()
-0.0% -9.82Ki  -0.1% -1.10Ki    TOTAL

Updated: 2026-03-31T14:32:38

github-actions · 2026-03-31T14:33:14Z

/en/mavlink/index.md

LinkedInternalPageMissing: This linked file is missing: ../mavlink/message_signing.md

mrpollo · 2026-03-31T15:08:40Z

I have a PR that fixes the issues give me time to get the feature tested. It won't take too long and we'll keep the signing support up to spec.

ttechnick · 2026-03-31T15:09:56Z

If the fix is close to be merged, i`ll close the PR.

mrpollo · 2026-03-31T15:19:56Z

Yep, I think we are close, just a matter of doing testing QGC to PX4, but I'm halfway done with that. Thanks for the PR.

mrpollo · 2026-03-31T18:39:10Z

I think this PR is now ready #26894

Revert "feat(mavlink): mavlink signing support (#25284)"

70d0ecf

This reverts commit 358574f.

ttechnick requested a review from mrpollo March 31, 2026 14:23

github-actions bot added the Documentation 📑 label Mar 31, 2026

ttechnick requested review from MaEtUgR and dakejahl March 31, 2026 14:24

ttechnick closed this Mar 31, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

revert(mavlink): Revert mavlink signing support (#25284)#26915

revert(mavlink): Revert mavlink signing support (#25284)#26915
ttechnick wants to merge 1 commit intomainfrom
pr-revert-mavlink-signing-temp

ttechnick commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

mrpollo commented Mar 31, 2026

Uh oh!

ttechnick commented Mar 31, 2026

Uh oh!

mrpollo commented Mar 31, 2026

Uh oh!

mrpollo commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ttechnick commented Mar 31, 2026

Solved Problem

Solution

Changelog Entry

Details

Uh oh!

github-actions bot commented Mar 31, 2026

💡 Commit messages could be improved

Uh oh!

github-actions bot commented Mar 31, 2026

🔎 FLASH Analysis

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

mrpollo commented Mar 31, 2026

Uh oh!

ttechnick commented Mar 31, 2026

Uh oh!

mrpollo commented Mar 31, 2026

Uh oh!

mrpollo commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants