Skip to content

fix(mavftp): don't use cache for other sys/comp ids#26934

Merged
alexcekay merged 1 commit intomainfrom
pr-mavftp-resend-fix
Apr 2, 2026
Merged

fix(mavftp): don't use cache for other sys/comp ids#26934
alexcekay merged 1 commit intomainfrom
pr-mavftp-resend-fix

Conversation

@alexcekay
Copy link
Copy Markdown
Member

@alexcekay alexcekay commented Apr 1, 2026

Solved Problem

When having two different mavftp clients (not parallel, this would cause a lot of problems anyway), it is possible that the resend logic will not send a reply to client B as it confuses it with client A.

This can happen in the following case:

Client A -> req (seq: 0) -> FMU
FMU -> repl -> Client A

<some time pass>

Client B -> req (seq: 0) -> FMU
No reply from FMU as payload->seq_number + 1 == last_payload->seq_number,
so nothing is sent to this client.

Especially if the retry of Client B is not implemented smart and it starts a new mavftp_client in those cases it will always start with seq 0 again and will get the same error over and over.

Solution

  • Do not use the cache when the request comes from a different sys/comp id

Alternatives

  • Clients should implement robust retries in any case. This is an additional robustness measure.

Test coverage

  • Tested on the bench with a v6n

@alexcekay alexcekay marked this pull request as ready for review April 1, 2026 11:10
@alexcekay alexcekay requested a review from bkueng April 1, 2026 11:10
Copy link
Copy Markdown
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find

@alexcekay alexcekay merged commit 56c69f4 into main Apr 2, 2026
88 checks passed
@alexcekay alexcekay deleted the pr-mavftp-resend-fix branch April 2, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants