Combine all battery failsafe configuration into COM_LOW_BAT_ACT to make the options very clear for the user#26955
Open
Combine all battery failsafe configuration into COM_LOW_BAT_ACT to make the options very clear for the user#26955
Conversation
…OW_BAT_ACT to make the options very clear for the user
❌ PR title needs conventional commit formatExpected format: Your title:
Suggested fix:
To fix this: click the ✏️ next to the PR title at the top of this page and update it. See CONTRIBUTING.md for details. This comment will be automatically removed once the issue is resolved. |
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: -48 byte (-0 %)]px4_fmu-v6x [Total VM Diff: -96 byte (-0 %)]Updated: 2026-04-02T16:44:30 |
|
No broken links found in changed files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
After #25267 users are missing the bingo fuel feature because it's very hard to know/remember there's a separate parameter which doesn't even have the word battery in its description.
Solution
Combine battery failsafe configuration into
COM_LOW_BAT_ACT. There are clear options to choose from and option 3 to have the full functionality stays the same such that previous users and airframes/products without any change stay like the originally worked.Changelog Entry
Test coverage
I couldn't test it yet. Would be nice to add efficient integration tests to constantly verify.