Skip to content

Combine all battery failsafe configuration into COM_LOW_BAT_ACT to make the options very clear for the user#26955

Open
MaEtUgR wants to merge 1 commit intomainfrom
maetugr/bingo-fuel-configuration
Open

Combine all battery failsafe configuration into COM_LOW_BAT_ACT to make the options very clear for the user#26955
MaEtUgR wants to merge 1 commit intomainfrom
maetugr/bingo-fuel-configuration

Conversation

@MaEtUgR
Copy link
Copy Markdown
Member

@MaEtUgR MaEtUgR commented Apr 2, 2026

Solved Problem

After #25267 users are missing the bingo fuel feature because it's very hard to know/remember there's a separate parameter which doesn't even have the word battery in its description.

Solution

Combine battery failsafe configuration into COM_LOW_BAT_ACT. There are clear options to choose from and option 3 to have the full functionality stays the same such that previous users and airframes/products without any change stay like the originally worked.

Changelog Entry

Combine all battery failsafe configuration into COM_LOW_BAT_ACT to make the options very clear for the user

Test coverage

I couldn't test it yet. Would be nice to add efficient integration tests to constantly verify.

…OW_BAT_ACT to make the options very clear for the user
@MaEtUgR MaEtUgR requested a review from ttechnick April 2, 2026 16:36
@MaEtUgR MaEtUgR self-assigned this Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

❌ PR title needs conventional commit format

Expected format: type(scope): description (conventional commits).

Your title:

Combine all battery failsafe configuration into COM_LOW_BAT_ACT to make the options very clear for the user

Suggested fix:

feat(battery): combine all battery failsafe configuration into COM_LOW_BAT_ACT to make the options very clear for the user

To fix this: click the ✏️ next to the PR title at the top of this page and update it.

See CONTRIBUTING.md for details.


This comment will be automatically removed once the issue is resolved.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: -48 byte (-0 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +75  [ = ]       0    .debug_abbrev
-0.0%      -8  [ = ]       0    .debug_aranges
-0.0%     -28  [ = ]       0    .debug_frame
-0.0% -2.89Ki  [ = ]       0    .debug_info
-0.0%    -154  [ = ]       0    .debug_line
  [NEW]      +3  [ = ]       0    [Unmapped]
  -0.0%    -157  [ = ]       0    [section .debug_line]
-0.0%    -142  [ = ]       0    .debug_loclists
-0.0%      -4  [ = ]       0    .debug_rnglists
  [NEW]      +1  [ = ]       0    [Unmapped]
  -0.0%      -5  [ = ]       0    [section .debug_rnglists]
-0.0%   -1022  [ = ]       0    .debug_str
+1.3%      +3  [ = ]       0    .shstrtab
-0.0%     -51  [ = ]       0    .strtab
  [NEW]     +11  [ = ]       0    CSWTCH.821
  [DEL]     -11  [ = ]       0    CSWTCH.824
  [DEL]     -51  [ = ]       0    Failsafe::fromRemainingFlightTimeLowActParam()
   +36%     +16  [ = ]       0    ___ZL19param_get_cplusplustPf.isra.0_veneer
 -40.0%     -16  [ = ]       0    __stm32_dmastart_veneer
-0.0%     -32  [ = ]       0    .symtab
  [NEW]     +32  [ = ]       0    CSWTCH.821
  [DEL]     -32  [ = ]       0    CSWTCH.824
 -25.0%     -16  [ = ]       0    Commander::handleCommandActuatorTest()
  +100%     +16  [ = ]       0    Commander::updateParameters()
 -50.0%     -32  [ = ]       0    EKFGSF_yaw::fuseVelocity()
   +33%     +16  [ = ]       0    Failsafe::checkStateAndMode()
   +20%     +16  [ = ]       0    Failsafe::fromOffboardLossActParam()
  [DEL]     -32  [ = ]       0    Failsafe::fromRemainingFlightTimeLowActParam()
   +25%     +16  [ = ]       0    Failsafe::isFailsafeIgnored()
 -50.0%     -16  [ = ]       0    Failsafe::updateArmingState()
   +13%     +32  [ = ]       0    ___ZL19param_get_cplusplustPf.isra.0_veneer
 -40.0%     -32  [ = ]       0    __stm32_dmastart_veneer
+0.4%     +48  [ = ]       0    [Unmapped]
-0.0%     -48  -0.0%     -48    .text
   +52%     +48   +52%     +48    Failsafe::fromBatteryWarningActParam()
  +0.0%     +12  +0.0%     +12    g_cromfs_image
  [NEW]      +4  [NEW]      +4    CSWTCH.821
  +1.0%      +4  +1.0%      +4    EKFGSF_yaw::fuseVelocity()
  +3.2%      +2  +3.2%      +2    Failsafe::updateArmingState()
  [DEL]      -4  [DEL]      -4    CSWTCH.824
  -2.0%      -4  -2.0%      -4    Commander::updateParameters()
  -4.5%      -4  -4.5%      -4    FlightTask
  -0.0%      -8  -0.0%      -8    px4::parameters
  -5.3%     -12  -5.3%     -12    Failsafe::updateParamsImpl()
  -0.0%     -16  -0.0%     -16    [section .text]
  -4.4%     -20  -4.4%     -20    Failsafe::Failsafe()
  [DEL]     -50  [DEL]     -50    Failsafe::fromRemainingFlightTimeLowActParam()
-0.0% -4.22Ki  -0.0%     -48    TOTAL

px4_fmu-v6x [Total VM Diff: -96 byte (-0 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +75  [ = ]       0    .debug_abbrev
-0.0%      -8  [ = ]       0    .debug_aranges
-0.0%     -48  [ = ]       0    .debug_frame
-0.0% -2.83Ki  [ = ]       0    .debug_info
-0.0%    -218  [ = ]       0    .debug_line
  +100%      +1  [ = ]       0    [Unmapped]
  -0.0%    -219  [ = ]       0    [section .debug_line]
-0.0%    -190  [ = ]       0    .debug_loclists
-0.0%     -12  [ = ]       0    .debug_rnglists
  +200%      +2  [ = ]       0    [Unmapped]
  -0.0%     -14  [ = ]       0    [section .debug_rnglists]
-0.0% -1.01Ki  [ = ]       0    .debug_str
-0.0%     -52  [ = ]       0    .strtab
  [NEW]     +11  [ = ]       0    CSWTCH.821
  [DEL]     -11  [ = ]       0    CSWTCH.824
  [DEL]     -51  [ = ]       0    Failsafe::fromRemainingFlightTimeLowActParam()
  -0.0%      -1  [ = ]       0    do_not_explicitly_use_this_namespace::Param<>::update()
-0.0%     -32  [ = ]       0    .symtab
  [NEW]     +32  [ = ]       0    CSWTCH.821
  [DEL]     -32  [ = ]       0    CSWTCH.824
 -25.0%     -16  [ = ]       0    Commander::handleCommandActuatorTest()
  +100%     +16  [ = ]       0    Commander::updateParameters()
  +100%     +16  [ = ]       0    ConstLayer::containedAsBitset()
  +100%     +32  [ = ]       0    EKFGSF_yaw::fuseVelocity()
   +33%     +16  [ = ]       0    Failsafe::checkStateAndMode()
   +20%     +16  [ = ]       0    Failsafe::fromOffboardLossActParam()
  [DEL]     -32  [ = ]       0    Failsafe::fromRemainingFlightTimeLowActParam()
   +25%     +16  [ = ]       0    Failsafe::isFailsafeIgnored()
 -50.0%     -16  [ = ]       0    Failsafe::updateArmingState()
  -0.6%     -64  [ = ]       0    [section .symtab]
 -25.0%     -16  [ = ]       0    param_import_internal()
+1.4%     +96  [ = ]       0    [Unmapped]
-0.0%     -96  -0.0%     -96    .text
   +52%     +48   +52%     +48    Failsafe::fromBatteryWarningActParam()
  [NEW]      +4  [NEW]      +4    CSWTCH.821
  +4.8%      +4  +4.8%      +4    FlightTask
   +50%      +4   +50%      +4    Zero
  +0.0%      +4  +0.0%      +4    g_cromfs_image
 -96.8%      +2 -96.8%      +2    [1 Others]
  [DEL]      -4  [DEL]      -4    CSWTCH.824
  -2.0%      -4  -2.0%      -4    Commander::updateParameters()
  -5.6%      -4  -5.6%      -4    ConstLayer::containedAsBitset()
  -1.0%      -4  -1.0%      -4    EKFGSF_yaw::fuseVelocity()
  -1.8%      -4  -1.8%      -4    param_foreach
  -1.3%      -4  -1.3%      -4    param_hash_check
  -1.3%      -4  -1.3%      -4    param_load
  -0.9%      -4  -0.9%      -4    param_reset_excludes
  -0.2%      -4  -0.2%      -4    px4::parameters_type
  -0.0%      -8  -0.0%      -8    px4::parameters
  -5.3%     -12  -5.3%     -12    Failsafe::updateParamsImpl()
  -0.0%     -16  -0.0%     -16    [section .text]
  -4.4%     -20  -4.4%     -20    Failsafe::Failsafe()
  -4.5%     -20  -4.5%     -20    param_reset_specific
  [DEL]     -50  [DEL]     -50    Failsafe::fromRemainingFlightTimeLowActParam()
-0.0% -4.31Ki  -0.0%     -96    TOTAL

Updated: 2026-04-02T16:44:30

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

No broken links found in changed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant