Merged
Conversation
Delete the nuttx_env_config workflow. It validated the PX4_EXTRA_NUTTX_CONFIG env var handling in platforms/nuttx/NuttX/CMakeLists.txt by building px4_fmu-v5_default with CONFIG_NSH_LOGIN_PASSWORD injected at configure time. The CI orchestrator rewrite (mrpollo/ci_orchestration, PR #26257) drops this workflow entirely. The cmake feature itself remains; only the CI gate is removed. Signed-off-by: Ramon Roche <mrpollo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
nuttx_env_configworkflow. It validated thePX4_EXTRA_NUTTX_CONFIGenv var handling inplatforms/nuttx/NuttX/CMakeLists.txtby buildingpx4_fmu-v5_defaultwithCONFIG_NSH_LOGIN_PASSWORDinjected at configure time.The CI orchestrator rewrite on
mrpollo/ci_orchestration(#26257) drops this workflow entirely, and in practice the matrix has been a quiet tax on every PR for a feature that no regression has ever caught here. The cmake handling ofPX4_EXTRA_NUTTX_CONFIGremains untouched: contributors can stillexport PX4_EXTRA_NUTTX_CONFIG="CONFIG_XY=y;CONFIG_Z=y"locally. Only the CI gate is removed.