fix(ekf2): fix observation_variance unit mismatch in comparison#27044
Open
fix(ekf2): fix observation_variance unit mismatch in comparison#27044
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a GNSS velocity units mismatch in Ekf::controlGnssYawEstimator() so the EKF-GSF yaw estimator receives and validates GNSS speed accuracy in the correct units (m/s) instead of variance (m²/s²).
Changes:
- Convert GNSS velocity observation variance to 1-sigma velocity accuracy using
sqrtf(). - Compare 1-sigma accuracy against
EKF2_REQ_SACC(m/s) instead of comparing variance to a speed threshold. - Pass 1-sigma accuracy (m/s) into
EKFGSF_yaw::fuseVelocity()as expected by its API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
This PR fixes a units mismatch in
Ekf::controlGnssYawEstimator().Previously, the code used
aid_src_vel.observation_variance[0](vel_var, in m^2/s^2) as if it were a 1-sigma speed accuracy (m/s):EKF2_REQ_SACC(m/s)EKFGSF_yaw::fuseVelocity(), which expects 1-sigma accuracy (m/s)Changelog Entry
For release notes: