fix(ci): stop pr-review-poster from spamming REQUEST_CHANGES on every push#27055
Merged
fix(ci): stop pr-review-poster from spamming REQUEST_CHANGES on every push#27055
Conversation
mrpollo
force-pushed
the
mrpollo/fix-review-poster-spam
branch
from
b9d2ad5 to
094238d
Compare
… push Branch protection rules block the GITHUB_TOKEN from dismissing reviews (HTTP 403), so every push added another undismissable REQUEST_CHANGES review. PR #27004 accumulated 12 identical blocking reviews. Switch to COMMENT-only reviews. Findings still show inline on the diff but don't create blocking reviews that require manual maintainer dismissal. The CI check status (pass/fail) gates merging, not the review state. Also enable CMAKE_TESTING=ON in the clang-tidy build so test files get proper include paths in compile_commands.json. Without this, clang-tidy-diff runs on test files from the PR diff but can't resolve gtest headers, producing false positives. Fixes #27004 Signed-off-by: Ramon Roche <mrpollo@gmail.com>
mrpollo
force-pushed
the
mrpollo/fix-review-poster-spam
branch
2 times, most recently
from
81588ad to
d9a2d7e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mrpollo
force-pushed
the
mrpollo/fix-review-poster-spam
branch
from
6ecc6d1 to
ce0a078
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch protection rules block the
GITHUB_TOKENfrom dismissing reviews (HTTP 403: "Branch protections do not permit dismissing this review"), so every push to a PR with clang-tidy findings added another undismissableREQUEST_CHANGESreview. PR #27004 accumulated 12 identical blocking reviews.Two changes:
Switch to COMMENT-only reviews (
pr-review-poster.py,pr-review-poster.yml,clang-tidy.yml):ACCEPTED_EVENTSnow only allowsCOMMENT, rejectingREQUEST_CHANGESat validation timeclang-tidy.yml) passes--event COMMENTinstead of--event REQUEST_CHANGESCOMMENTEDreviews (non-blocking, no dismissal needed)dismiss_stale_reviewsnow returns a count of failed dismissals and logs it, instead of silently swallowing errorsFindings still show inline on the "Files changed" tab. The CI check status (pass/fail) is what actually gates merging.
Exclude test files from clang-tidy-diff (
clang-tidy.yml):clang-tidy-diff-18.pyruns on the raw git diff, notcompile_commands.jsonBUILD_TESTING=OFF) appear in the diff but gtest headers aren't available, producing false positives likegtest/gtest.h not found(seen on fix(navigator): rtl compute wind angle to select best land approach based on rally point location instead of home location #27004)git diff ... -- ':!*/test/*'filters test paths from the diff before piping to clang-tidy-diffrun-clang-tidy-pr.py(the non-artifact path) already handles this correctly by checking againstcompile_commands.jsonCMAKE_TESTING=ONwas considered but fails in the clang build (abseil can't find pthreads with the clang-only toolchain in the container)