Open
Conversation
Jaeyoung-Lim
requested changes
Jul 13, 2025
Member
There was a problem hiding this comment.
Thanks! Looks great.
My only concern is whether the license of the model is compatible with this repository.
If the model is licensed under Apache 2.0, as the original vrx repo is licensed as, you need to add additional license files to be compatible with the license. (See https://opensource.stackexchange.com/questions/11556/can-i-use-apache-2-0-licensed-project-inside-my-bsd-3-clause-licensed-project)
|
|
||
| <author email="briansbingham@gmail.com">Brian Bingham</author> | ||
| <author email="caguero@osrfoundation.org">Carlos Aguero</author> | ||
| <author email="stephencferro@gmail.com">Stephen Ferro</author> |
Member
There was a problem hiding this comment.
Could you clarify the license of the model that you modified? (Not the one in vrx, but the one that you ported)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports the boat model from Gazebo Classic to Ignition with USV hydrodynamics support via a new USV Dynamics Gazebo plugin. Both the model and plugin are designed to directly replicate the existing SITL functionality in Gazebo Classic.
Screencast.from.07-12-2025.02.59.24.PM.webm
Associated PX4-Autopilot PR
Related Issues:
Issue #110