Skip to content

Conversation

@zhoutianzi666
Copy link
Collaborator

@zhoutianzi666 zhoutianzi666 commented Dec 29, 2025

Motivation

RDMACommManager 构造函数中的rank参数没有用到,给删掉

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

RDMACommManager 构造函数中的rank参数没有用到,给删掉

Usage or Command

None

Accuracy Tests

None

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@91a2b13). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5814   +/-   ##
==========================================
  Coverage           ?   66.44%           
==========================================
  Files              ?      337           
  Lines              ?    43082           
  Branches           ?     6639           
==========================================
  Hits               ?    28624           
  Misses             ?    12333           
  Partials           ?     2125           
Flag Coverage Δ
GPU 66.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhoutianzi666 zhoutianzi666 changed the title remove useless code [PD Disaggregation]remove useless code Dec 30, 2025
@zhoutianzi666 zhoutianzi666 changed the title [PD Disaggregation]remove useless code [PD Disaggregation]remove unsed para in RDMACommManager Dec 30, 2025
@zhoutianzi666 zhoutianzi666 merged commit 7ae13b2 into PaddlePaddle:develop Dec 30, 2025
17 of 22 checks passed
@zhoutianzi666 zhoutianzi666 deleted the remove_useless_code1 branch December 30, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants