Skip to content

[Cherry-Pick] [BugFix] resolve get_save_output_v1 socket name conflicts between multiple instances (#6758)#6767

Open
liyonghua0910 wants to merge 2 commits intoPaddlePaddle:release/2.4from
liyonghua0910:release/2.4+fix_get_save_v1_0310
Open

[Cherry-Pick] [BugFix] resolve get_save_output_v1 socket name conflicts between multiple instances (#6758)#6767
liyonghua0910 wants to merge 2 commits intoPaddlePaddle:release/2.4from
liyonghua0910:release/2.4+fix_get_save_v1_0310

Conversation

@liyonghua0910
Copy link
Collaborator

Motivation

When FD_USE_GET_SAVE_OUTPUT_V1 is enabled, the ZMQ socket name is currently derived only from local_data_parallel_id. In multi-instance deployments on the same machine, different instances can end up using the same socket name, which may cause IPC

Modifications

  • Updated the get_save_output_v1 socket naming rule to include local_engine_worker_queue_port in addition to local_data_parallel_id
  • Aligned both server and client socket names across:
    • token_processor
    • gpu_model_runner
    • metax_model_runner
    • xpu_model_runner
  • Updated tests/output/test_get_save_output_v1.py to reflect the new socket naming logic

Usage or Command

As usual

Accuracy Tests

No side effect on accuracy

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Mar 10, 2026

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/2.4@7fb8af4). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release/2.4    #6767   +/-   ##
==============================================
  Coverage               ?   56.20%           
==============================================
  Files                  ?      333           
  Lines                  ?    42391           
  Branches               ?     6453           
==============================================
  Hits                   ?    23825           
  Misses                 ?    16704           
  Partials               ?     1862           
Flag Coverage Δ
GPU 56.20% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants