[Cherry-Pick] [BugFix] resolve get_save_output_v1 socket name conflicts between multiple instances (#6758)#6767
Open
liyonghua0910 wants to merge 2 commits intoPaddlePaddle:release/2.4from
Conversation
|
Thanks for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/2.4 #6767 +/- ##
==============================================
Coverage ? 56.20%
==============================================
Files ? 333
Lines ? 42391
Branches ? 6453
==============================================
Hits ? 23825
Misses ? 16704
Partials ? 1862
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When
FD_USE_GET_SAVE_OUTPUT_V1is enabled, the ZMQ socket name is currently derived only fromlocal_data_parallel_id. In multi-instance deployments on the same machine, different instances can end up using the same socket name, which may cause IPCModifications
get_save_output_v1socket naming rule to includelocal_engine_worker_queue_portin addition tolocal_data_parallel_idtoken_processorgpu_model_runnermetax_model_runnerxpu_model_runnertests/output/test_get_save_output_v1.pyto reflect the new socket naming logicUsage or Command
As usual
Accuracy Tests
No side effect on accuracy
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.