Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

## 2024-05-24 - [Optimize RequestMetrics.to_dict serialization]
**Learning:** `dataclasses.asdict` does deep copies, which incurs significant overhead for frequently serialized dataclasses like `RequestMetrics` in a hotpath like the API server.
**Action:** Use manual `__slots__` iteration with `getattr` for faster serialization when the dataclass structure is mostly primitives, while only falling back to `asdict` for nested dataclasses lacking slots (like `SpeculateMetrics`).
9 changes: 8 additions & 1 deletion fastdeploy/engine/request.py
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,14 @@ def to_dict(self):
"""
Convert the RequestMetrics object to a dictionary.
"""
return {k: v for k, v in asdict(self).items()}
res = {}
for key in self.__dataclass_fields__:
v = getattr(self, key)
if v is not None and hasattr(v, "__dataclass_fields__"):
res[key] = asdict(v)
else:
res[key] = v
return res

def record_recv_first_token(self):
cur_time = time.time()
Expand Down
Loading