[API compatibility] Add nn.Module,nn.ModuleList,nn,ModuleDict #756
+112
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhwesky2010
reviewed
Nov 14, 2025
tests/test_nn_Module_zero_grad.py
Outdated
|
|
||
|
|
||
| def test_case_1(): | ||
| def _test_case_1(): |
Collaborator
There was a problem hiding this comment.
这个地方能对齐吗，是框架API有问题吗
zhanghonggeng
force-pushed
the
api1
branch
2 times, most recently
from
9c8d6e9 to
eb54811
Compare
zhwesky2010
reviewed
Nov 24, 2025
| import pytest | ||
| from apibase import APIBase | ||
|
|
||
| # 本地测试通过，paconvert中api_mapping中会将torch.Tensor.cuda进行转换，导致出现不存在参数device_id |
Collaborator
There was a problem hiding this comment.
这个是因为torch.Tensor.cuda未对齐的原因吗
| if self.get_paddle_api(): | ||
| new_paddle_api = re.sub( | ||
| "paddle.Tensor|paddle.nn.Layer|paddle.optimizer.Optimizer|paddle.distribution.Distribution|paddle.autograd.PyLayerContext|paddle.profiler.Profiler", | ||
| "paddle.Tensor|paddle.nn.Layer|paddle.nn.Module|paddle.optimizer.Optimizer|paddle.distribution.Distribution|paddle.autograd.PyLayerContext|paddle.profiler.Profiler", |
Collaborator
There was a problem hiding this comment.
PaConvert里所有的paddle.nn.Layer后续都可以不维护了，统一都更新到paddle.nn.Module吧
|
|
||
|
|
||
| def _test_case_1(): | ||
| def test_case_1(): |
| "torch.Tensor.sub", | ||
| "torch.Tensor.sub_", | ||
| "torch.Tensor.random_", | ||
| "torch.meshgrid", |
Collaborator
There was a problem hiding this comment.
确认下：所有能对齐的都填上了吧，另外都存在单测吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
新增nn.Module,nn.ModuleList,nn,ModuleDict和torch.meshgrid
其中nn.Module.zero_grad中不支持直接将p.grad设置为None，当前使用clear_gradient代替。
PR APIs