Skip to content

【Hackathon 8th No.3】 clean oldIR for engine #71929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

【Hackathon 8th No.3】 clean oldIR for engine #71929

wants to merge 36 commits into from

Conversation

aquagull
Copy link
Contributor

PR Category

Auto Parallel

PR Types

Others

Description

clean oldIR in engine.py

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Mar 26, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 26, 2025
@aquagull aquagull changed the title Engine 【Hackathon 8th No.3】 clean oldIR for engine -part Mar 28, 2025
@luotao1 luotao1 mentioned this pull request Mar 28, 2025
Open
@aquagull aquagull changed the title 【Hackathon 8th No.3】 clean oldIR for engine -part 【Hackathon 8th No.3】 clean oldIR for engine Apr 3, 2025
liym27
liym27 reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto_parallel_autoconvert_deprecated.py 有PIR下的对应测试吗？
test_standalone_executor_multi_micro_batch_deprecated.py test/standalone_executor/test_standalone_custom_event.py 这2个单测为什么要删呢

@aquagull
Copy link
Contributor Author

auto_parallel_autoconvert_deprecated.py 有PIR下的对应测试吗？ test_standalone_executor_multi_micro_batch_deprecated.py test/standalone_executor/test_standalone_custom_event.py 这2个单测为什么要删呢

已经把这几个单测回退。删除的单测都会进入老IR分支。之后选择保留这部分的老IR分支来兼容这几个单测

liym27
liym27 previously approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddle-ci-bot Paddle-ci-bot
Copy link

paddle-ci-bot bot commented Apr 22, 2025

Sorry to inform you that 73b23be's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo left review comments

@liym27 liym27 liym27 left review comments

@zrr1999 zrr1999 Awaiting requested review from zrr1999

@gouzil gouzil Awaiting requested review from gouzil

At least 1 approving review is required to merge this pull request.

Assignees

@luotao1 luotao1

@liym27 liym27

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aquagull @liym27 @SigureMo @luotao1