Skip to content

[Test] Move cpp unittests to test directory#75632

Merged
SigureMo merged 15 commits intoPaddlePaddle:developfrom
cattidea:test/move-cpp-unittests-to-test-dir
Oct 11, 2025
Merged

[Test] Move cpp unittests to test directory#75632
SigureMo merged 15 commits intoPaddlePaddle:developfrom
cattidea:test/move-cpp-unittests-to-test-dir

Conversation

@SigureMo
Copy link
Copy Markdown
Member

@SigureMo SigureMo commented Sep 30, 2025

PR Category

Environment Adaptation

PR Types

Improvements

Description

paddle/fluid/framework/ir/ 单测统一移到 test/cpp/fluid/framework/ir/ 目录

Co-authored with GitHub Copilot Agent with Claude Sonnet 4.5 model

SigureMo and others added 2 commits September 30, 2025 17:02
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@SigureMo SigureMo requested a review from Copilot September 30, 2025 09:04
@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Sep 30, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves C++ unit tests from the paddle/fluid/framework/ir/ directory to the new test/cpp/legacy_ir/ directory, reorganizing the test structure to consolidate tests under the unified test directory.

  • Migrates all legacy IR pass tests from source directory to dedicated test directory
  • Creates new CMakeLists.txt files organizing tests by functionality (onednn, xpu, fusion_group)
  • Updates main CMakeLists.txt to include the new legacy_ir subdirectory

Reviewed Changes

Copilot reviewed 8 out of 72 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/cpp/CMakeLists.txt Adds subdirectory reference for legacy_ir tests
test/cpp/legacy_ir/CMakeLists.txt Main CMakeLists organizing all legacy IR tests
test/cpp/legacy_ir/onednn/CMakeLists.txt OneDNN-specific test configuration
test/cpp/legacy_ir/xpu/CMakeLists.txt XPU-specific test configuration
test/cpp/legacy_ir/fusion_group/CMakeLists.txt Fusion group test configuration
test/cpp/legacy_ir/op_compat_sensible_pass_test.cc Reorders include statements
test/cpp/legacy_ir/generate_pass_test.cc Reorders include statements
paddle/fluid/framework/ir/CMakeLists.txt Removes all test definitions (290+ lines)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread test/cpp/legacy_ir/op_compat_sensible_pass_test.cc
Comment thread test/cpp/legacy_ir/generate_pass_test.cc
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@f9b74fc). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             develop    #75632   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         2           
  Lines              ?         9           
  Branches           ?         0           
===========================================
  Hits               ?         9           
  Misses             ?         0           
  Partials           ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SigureMo SigureMo requested a review from Copilot October 11, 2025 10:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 13 out of 77 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread test/cpp/fluid/framework/ir/CMakeLists.txt Outdated
Comment thread test/cpp/fluid/framework/ir/CMakeLists.txt Outdated
Comment thread paddle/fluid/framework/op_desc.h
SigureMo and others added 2 commits October 11, 2025 18:49
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@swgu98 swgu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L巨GTM

@SigureMo SigureMo merged commit 2c02b6c into PaddlePaddle:develop Oct 11, 2025
72 of 77 checks passed
@SigureMo SigureMo deleted the test/move-cpp-unittests-to-test-dir branch October 11, 2025 15:16
SigureMo added a commit to cattidea/Paddle that referenced this pull request Oct 14, 2025
---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants