[DLPack] Bump DLPack to v1.2 and implement C functions exchange API#75650
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
This reverts commit 2a9fc21.
bc1743e to
c1735e4
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (30.76%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #75650 +/- ##
==========================================
Coverage ? 30.76%
==========================================
Files ? 2
Lines ? 13
Branches ? 0
==========================================
Hits ? 4
Misses ? 9
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } catch (const std::exception &e) { | ||
| PyErr_SetString(PyExc_RuntimeError, e.what()); | ||
| return -1; |
There was a problem hiding this comment.
这里只需要管 std::exception,不需要管其他的异常吗?类似这样的?
try {
// 代码
} catch (const std::exception& e) {
// 处理标准异常
} catch (...) {
// 处理所有其他异常
}There was a problem hiding this comment.
协议模板,这里不应该动
PR Category
Execute Infrastructure
PR Types
New features
Description
Implement C functions for speed dlpack exchange and stream handling and bump DLPack to v1.2. Refer to https://github.com/apache/tvm-ffi/blob/main/python/tvm_ffi/_optional_torch_c_dlpack.py and dmlc/dlpack#174
TODOs
__c_dlpack_*methods to__c_dlpack_exchange_api__after [RFC] Support DLPACK C Functions for Speed Exchange and Stream Handling dmlc/dlpack#174 merged__c_dlpack_*APIs__c_dlpack_exchange_api__implementation on Flashinfer (needs [DLPack] C Functions for DLPack Speed Exchange and Stream Handling apache/tvm-ffi#96)__c_dlpack_exchange_api__