[CI] Add Report Preview URLs Workflow#75687
Merged
SigureMo merged 5 commits intoPaddlePaddle:developfrom Oct 12, 2025
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
/re-run all-failed |
SigureMo
reviewed
Oct 11, 2025
| api_obj = resolve_string_to_obj(api) | ||
|
|
||
| if api_obj is None: | ||
| raise ValueError(f"Could not resolve API path: {api}") |
Member
There was a problem hiding this comment.
当前处理逻辑不能保证全部 obj 都非 None 吧？这会导致 _Doc-Preview 流水线挂掉？
因为这个 comment 完全是可选的，如果让 preview 流水线挂掉不太合适，这里能做到尽可能不报错么？而是在发生报错时/想要报错时，将报错信息生成到 comment_body 里，加上 @ooooo-create，通知修复
Contributor
Author
There was a problem hiding this comment.
好的，已修改~，已经改到了 comment_body 里面，解析到的 api 应该是都能 load 的，这里是显式 check 了一下~
… judgment logic of Class.xxxx
SigureMo
approved these changes
Oct 12, 2025
SigureMo
pushed a commit
to cattidea/Paddle
that referenced
this pull request
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
New features
Description
当
python tools/diff_api.py触发需要构建文档的时候，并且涉及修改或新增 api 文档时，才会进行 comment。如果不需要重新构建或者都是删除 api 就不会进行评论cc @SigureMo