[Bug fix] fix#75804
Closed
youge325 wants to merge 1 commit intoPaddlePaddle:developfrom
Closed
Conversation
更新把 bfloat16.h 中 `isinf` 的判定从 `(a.x & 0x7F80) == 0x7F80` 改成 `(a.x & 0x7FFF) == 0x7F80`，意义在于： - 旧实现只屏蔽掉最高位的符号位，同时也在掩码里清除了 7 位尾数。当遇到 NaN（指数全 1、尾数非 0）时 `(a.x & 0x7F80)` 仍然等于 `0x7F80`，误把 NaN 判断成 Inf。 - 新实现在保留尾数位的情况下再比较，当尾数非零时与 `0x7F80` 不相等，因此能正确地区分 NaN 与 Inf。这让 `isinf` 只在尾数为 0 的 ±∞ 上返回 true，不会再误报 NaN。 这个改动修复了 bfloat16 类型上 `isinf` 对 NaN 的误判，提高了数值检查的准确性。
|
你的PR提交成功，感谢你对开源项目的贡献! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
更新把 bfloat16.h 中
isinf的判定从(a.x & 0x7F80) == 0x7F80改成(a.x & 0x7FFF) == 0x7F80，意义在于：(a.x & 0x7F80)仍然等于0x7F80，误把 NaN 判断成 Inf。0x7F80不相等，因此能正确地区分 NaN 与 Inf。这让isinf只在尾数为 0 的 ±∞ 上返回 true，不会再误报 NaN。这个改动修复了 bfloat16 类型上
isinf对 NaN 的误判，提高了数值检查的准确性。