[API Compatibility No.360] Sink paddle.inverse to cpp -part #77078

Manfredss · 2025-12-24T21:43:28Z

PR Category

User Experience

PR Types

New features

Description

Sink paddle.inverse to cpp
Add param alias for x
Add new param out

paddle-bot · 2025-12-24T21:43:33Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

codecov-commenter · 2025-12-25T02:24:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@304d5c2). Learn more about missing BASE report.

Additional details and impacted files

@@             Coverage Diff             @@
##             develop    #77078   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         1           
  Branches           ?         0           
===========================================
  Hits               ?         1           
  Misses             ?         0           
  Partials           ?         0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Manfredss · 2025-12-25T04:39:58Z

/re-run all-failed

zhwesky2010 · 2025-12-25T11:43:52Z

python/paddle/_paddle_docs.py

 """,
 )
+
+add_doc_and_signature(


可以往这个文件里的中间插入，不然PR容易前后自己冲突。

zhwesky2010

PR冲突了，_paddle_docs.py这个文件容易冲突。可以都往最后面加。

zhwesky2010 · 2025-12-26T03:46:19Z

python/paddle/_paddle_docs.py

 )
+
+
+add_doc_and_signature(


gcd下沉了吗，没下沉直接在python api的位置维护文档和签名，这里不需要加。

zhwesky2010 · 2025-12-26T03:55:54Z

python/paddle/_paddle_docs.py

+)
+
+
+add_doc_and_signature(


这些都是用于c++下沉的

zhwesky2010 · 2025-12-26T03:57:03Z

python/paddle/tensor/math.py

+        out_res, _ = paddle.static.nn.while_loop(
+            _gcd_cond_fn, _gcd_body_fn, [x, y]
+        )
+        if out is not None:


上下两个out分支可以合并下处理

zhwesky2010 · 2025-12-26T05:46:59Z

python/paddle/tensor/math.py


-@param_two_alias(['x', 'input'], ['y', 'other'])
-def gcd(x: Tensor, y: Tensor, name: str | None = None) -> Tensor:
+@ParamAliasDecorator({"x": ["input"], "y": ["other"]})


这个装饰器性能要比param_two_alias差点，后面还是可以直接用param_two_alias

python/paddle/_paddle_docs.py

Co-authored-by: Nyakku Shigure <[email protected]>

Manfredss · 2025-12-31T06:41:06Z

/re-run all-failed

zhwesky2010

冲突需要重新处理下。

zhwesky2010

LGTM

zhwesky2010 · 2026-01-13T09:58:07Z

@Manfredss 这个PR review已经没问题了，但是还有很多CI没有通过，尽快看下，不然阻碍无法合入。

… ApiEnhance_inverse

Manfredss · 2026-01-15T09:01:47Z

/re-run all-failed

zhwesky2010 · 2026-01-15T10:41:28Z

@Manfredss 冲突了

… ApiEnhance_inverse

zhwesky2010 · 2026-01-19T04:19:07Z

python/paddle/_paddle_docs.py

+            [[0.50000000, 0.        ],
+             [0.        , 0.50000000]])
+
+    """,


缩进不符合规范，参考目前其他的add_doc_and_signature

zhwesky2010 · 2026-01-19T04:19:27Z

python/paddle/tensor/math.py


-@param_two_alias(['x', 'input'], ['y', 'other'])
-def gcd(x: Tensor, y: Tensor, name: str | None = None) -> Tensor:
+@ParamAliasDecorator({"x": ["input"], "y": ["other"]})


这个不需要改了

zhwesky2010 · 2026-01-19T04:19:34Z

python/paddle/tensor/math.py


-@param_two_alias(['x', 'input'], ['y', 'other'])
-def lcm(x: Tensor, y: Tensor, name: str | None = None) -> Tensor:
+@ParamAliasDecorator({"x": ["input"], "y": ["other"]})


不需要改了

zhwesky2010 · 2026-01-19T04:19:50Z

python/paddle/tensor/math.py

-@param_two_alias(['x', 'input'], ['y', 'other'])
-def gcd(x: Tensor, y: Tensor, name: str | None = None) -> Tensor:
+@ParamAliasDecorator({"x": ["input"], "y": ["other"]})
+def gcd(


out参数未覆盖

… ApiEnhance_inverse

Manfredss · 2026-01-21T07:02:04Z

/re-run all-failed

zhwesky2010 · 2026-01-21T10:06:45Z

test/legacy_test/test_inverse_op.py

+        paddle.disable_static()
+        x = paddle.to_tensor(self.np_input)
+
+        # 使用所有支持的别名进行测试


代码库里不要加中文

Manfredss · 2026-01-22T01:56:33Z

/re-run all-failed

zhwesky2010 · 2026-01-22T04:15:52Z

@Manfredss 这个下沉后有些case无法通过了，你本地测试下看什么问题。
https://github.com/PaddlePaddle/PaddleTest/blob/develop/framework/api/linalg/test_inv.py

CI-Build / CE-Framework / Test (pull_request) 测试结果失败：

Manfredss · 2026-01-22T05:18:42Z

@Manfredss 这个下沉后有些case无法通过了，你本地测试下看什么问题。

这个测试文件里为什么是 @pytest.mark.api_linalg_det_vartype 而不是 @pytest.mark.api_linalg_inv_vartype？
然后应该要把 apibase.py 里的

if isfunction(func)

判断改为

if isfunction(func) or callable(func) and not hasattr(func, '__mro__')

使其能够正确识别 builtin_function_or_method 类型（如 paddle.linalg.inv）作为函数而不是类

zhwesky2010 · 2026-01-22T07:08:06Z

@Manfredss 这个下沉后有些case无法通过了，你本地测试下看什么问题。

这个测试文件里为什么是 @pytest.mark.api_linalg_det_vartype 而不是 @pytest.mark.api_linalg_inv_vartype？然后应该要把 apibase.py 里的
if isfunction(func)
判断改为
if isfunction(func) or callable(func) and not hasattr(func, '__mro__')
使其能够正确识别 builtin_function_or_method 类型（如 paddle.linalg.inv）作为函数而不是类

在paddle/_init_.py最后会 monkey_patch_generated_methods_for_tensor，重新将公开API：paddle.*、paddle.tensor.*、F.* 换成有python接口的，而paddle.linalg.inv导入了原始的pybind的inverse。这里需要看看调整下这一系列导入方式。在patch完之后，再从from paddle.tensor import inverse as inv就没问题。

Manfredss · 2026-01-22T07:54:36Z

@Manfredss 这个下沉后有些case无法通过了，你本地测试下看什么问题。

这个测试文件里为什么是 @pytest.mark.api_linalg_det_vartype 而不是 @pytest.mark.api_linalg_inv_vartype？然后应该要把 apibase.py 里的
if isfunction(func)
判断改为
if isfunction(func) or callable(func) and not hasattr(func, '__mro__')
使其能够正确识别 builtin_function_or_method 类型（如 paddle.linalg.inv）作为函数而不是类
在paddle/init.py最后会 monkey_patch_generated_methods_for_tensor，重新将公开API：paddle.*、paddle.tensor.*、F.* 换成有python接口的，而paddle.linalg.inv导入了原始的pybind的inverse。这里需要看看调整下这一系列导入方式。在patch完之后，再从from paddle.tensor import inverse as inv就没问题。

我看看

sink inverse to cpp

04869b2

paddle-bot bot added the contributor External developers label Dec 24, 2025

luotao1 mentioned this pull request Dec 25, 2025

【启航计划】PaddlePaddle API兼容性增强 #76301

Open

Manfredss mentioned this pull request Dec 25, 2025

[API Compatibility No.360] add torch.inverse -part PaddlePaddle/PaConvert#796

Open

zhwesky2010 reviewed Dec 25, 2025

View reviewed changes

zhwesky2010 added the API Compatibility label Dec 26, 2025

add out param to gcd and lcm

4547e2d

zhwesky2010 reviewed Dec 26, 2025

View reviewed changes

resolve conflict, simplify out return logic of gcd

7fb7e75

Manfredss requested review from JiabinYang and xiaoguoguo626807 as code owners December 26, 2025 04:53

Manfredss closed this Dec 26, 2025

Manfredss reopened this Dec 26, 2025

zhwesky2010 reviewed Dec 26, 2025

View reviewed changes

zhwesky2010 previously approved these changes Dec 26, 2025

View reviewed changes

zhwesky2010 requested a review from SigureMo December 26, 2025 05:47

SigureMo reviewed Dec 26, 2025

View reviewed changes

python/paddle/_paddle_docs.py Outdated Show resolved Hide resolved

python/paddle/_paddle_docs.py Show resolved Hide resolved

Apply suggestion from @SigureMo

8a20c4c

Co-authored-by: Nyakku Shigure <[email protected]>

Manfredss dismissed zhwesky2010’s stale review via 8a20c4c December 26, 2025 06:58

Update python/paddle/_paddle_docs.py

7d294ec

Co-authored-by: Nyakku Shigure <[email protected]>

SigureMo previously approved these changes Dec 26, 2025

View reviewed changes

Merge branch 'develop' into ApiEnhance_inverse

351f02c

Manfredss dismissed SigureMo’s stale review via 351f02c December 30, 2025 04:35

zhwesky2010 reviewed Jan 7, 2026

View reviewed changes

Manfredss and others added 2 commits January 10, 2026 13:56

Merge branch 'develop' into ApiEnhance_inverse

e76806d

fix code style

a368c47

zhwesky2010 previously approved these changes Jan 12, 2026

View reviewed changes

SigureMo previously approved these changes Jan 12, 2026

View reviewed changes

Manfredss added 2 commits January 14, 2026 17:41

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

d0204f5

… ApiEnhance_inverse

fix

64e8528

Manfredss dismissed stale reviews from SigureMo and zhwesky2010 via 64e8528 January 14, 2026 21:16

Manfredss added 3 commits January 16, 2026 09:47

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

5fc7380

… ApiEnhance_inverse

add test

4f8d4a6

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

7aef806

… ApiEnhance_inverse

Manfredss force-pushed the ApiEnhance_inverse branch from cdc20e0 to 7aef806 Compare January 16, 2026 04:16

zhwesky2010 reviewed Jan 19, 2026

View reviewed changes

Manfredss and others added 5 commits January 20, 2026 09:06

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

e31d13c

… ApiEnhance_inverse

fix, increase code coverage

3e63c12

Update math.py

6a638b0

Merge branch 'PaddlePaddle:develop' into ApiEnhance_inverse

9015edc

fix code style

d40f1c1

zhwesky2010 reviewed Jan 21, 2026

View reviewed changes

remove zh characters

996358e

SigureMo approved these changes Jan 22, 2026

View reviewed changes

zhwesky2010 approved these changes Jan 22, 2026

View reviewed changes

		)


		add_doc_and_signature(

		)


		add_doc_and_signature(

[API Compatibility No.360] Sink paddle.inverse to cpp -part #77078

Are you sure you want to change the base?

[API Compatibility No.360] Sink paddle.inverse to cpp -part #77078

Conversation

Manfredss commented Dec 24, 2025

PR Category

PR Types

Description

Uh oh!

paddle-bot bot commented Dec 24, 2025

Uh oh!

codecov-commenter commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Manfredss commented Dec 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Manfredss commented Dec 31, 2025

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

zhwesky2010 commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Manfredss commented Jan 15, 2026

Uh oh!

zhwesky2010 commented Jan 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Manfredss commented Jan 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Manfredss commented Jan 22, 2026

Uh oh!

zhwesky2010 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Manfredss commented Jan 22, 2026

Uh oh!

zhwesky2010 commented Jan 22, 2026

Uh oh!

Manfredss commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Dec 25, 2025 •

edited

Loading

zhwesky2010 commented Jan 13, 2026 •

edited

Loading

zhwesky2010 commented Jan 22, 2026 •

edited

Loading