-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Refine NCCL search logic #77459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine NCCL search logic #77459
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refines the NCCL library search logic by adding a new flag to control whether to search for NCCL in system paths when using pip CUDA libraries. This provides more control over library loading behavior for users with pip-installed CUDA packages.
Changes:
- Added a new boolean flag
search_nccl_in_system(default: false) to control system path searching for NCCL - Extended
GetDsoHandleFromSearchPathfunction with an optionalsearch_system_pathparameter (default: true) to conditionally skip system default path searching - Applied the new flag specifically to NCCL loading when
PADDLE_WITH_PIP_CUDA_LIBRARIESis defined
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| paddle/common/flags.cc | Defines the new search_nccl_in_system flag with appropriate documentation |
| paddle/phi/backends/dynload/dynamic_loader.cc | Declares the flag, adds search_system_path parameter to GetDsoHandleFromSearchPath, and applies the flag to NCCL loading in pip CUDA library builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paddle/common/flags.cc
Outdated
|
|
||
| PHI_DEFINE_EXPORTED_bool( | ||
| search_nccl_in_system, | ||
| false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
默认不查找的话,是否会再次出现之前 benchmark 平台上的问题?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #77459 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 2
Lines ? 2
Branches ? 0
===========================================
Hits ? 2
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR Category
Environment Adaptation
PR Types
Others
Description
统一 nvidia-nccl-cu12 为 2.28.3