Skip to content

Conversation

@ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Jan 21, 2026

PR Category

Environment Adaptation

PR Types

Others

Description

统一 nvidia-nccl-cu12 为 2.28.3

Copilot AI review requested due to automatic review settings January 21, 2026 08:04
@paddle-bot
Copy link

paddle-bot bot commented Jan 21, 2026

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the NCCL library search logic by adding a new flag to control whether to search for NCCL in system paths when using pip CUDA libraries. This provides more control over library loading behavior for users with pip-installed CUDA packages.

Changes:

  • Added a new boolean flag search_nccl_in_system (default: false) to control system path searching for NCCL
  • Extended GetDsoHandleFromSearchPath function with an optional search_system_path parameter (default: true) to conditionally skip system default path searching
  • Applied the new flag specifically to NCCL loading when PADDLE_WITH_PIP_CUDA_LIBRARIES is defined

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
paddle/common/flags.cc Defines the new search_nccl_in_system flag with appropriate documentation
paddle/phi/backends/dynload/dynamic_loader.cc Declares the flag, adds search_system_path parameter to GetDsoHandleFromSearchPath, and applies the flag to NCCL loading in pip CUDA library builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

risemeup1
risemeup1 previously approved these changes Jan 21, 2026
@ooooo-create ooooo-create marked this pull request as draft January 21, 2026 10:50

PHI_DEFINE_EXPORTED_bool(
search_nccl_in_system,
false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认不查找的话,是否会再次出现之前 benchmark 平台上的问题?

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@d5a87b6). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             develop    #77459   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         2           
  Lines              ?         2           
  Branches           ?         0           
===========================================
  Hits               ?         2           
  Misses             ?         0           
  Partials           ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ooooo-create ooooo-create marked this pull request as ready for review January 21, 2026 13:33
@ooooo-create ooooo-create merged commit a560c04 into PaddlePaddle:develop Jan 22, 2026
86 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants