Skip to content

[bug fixes]Fix recompute crash when pipeline-parallel releases closure-captured tensors before backward#78531

Merged
ForFishes merged 1 commit intoPaddlePaddle:developfrom
adam-xiaoyao:fix_recompute
Apr 1, 2026
Merged

[bug fixes]Fix recompute crash when pipeline-parallel releases closure-captured tensors before backward#78531
ForFishes merged 1 commit intoPaddlePaddle:developfrom
adam-xiaoyao:fix_recompute

Conversation

@adam-xiaoyao
Copy link
Copy Markdown
Contributor

@adam-xiaoyao adam-xiaoyao commented Mar 30, 2026

PR Category

Distributed Strategy

PR Types

Bug fixes

Description

Fix recompute crash when pipeline-parallel releases closure-captured tensors before backward

是否引起精度变化

@paddle-bot
Copy link
Copy Markdown

paddle-bot bot commented Mar 30, 2026

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@adam-xiaoyao
Copy link
Copy Markdown
Contributor Author

/re-run all-failed

@adam-xiaoyao adam-xiaoyao changed the title fix bug in recompute.py [bug fix]Fix recompute crash when pipeline-parallel releases closure-captured tensors before backward Mar 31, 2026
@adam-xiaoyao adam-xiaoyao changed the title [bug fix]Fix recompute crash when pipeline-parallel releases closure-captured tensors before backward [bug fixes]Fix recompute crash when pipeline-parallel releases closure-captured tensors before backward Mar 31, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@571341b). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             develop    #78531   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?        32           
  Branches           ?         0           
===========================================
  Hits               ?        32           
  Misses             ?         0           
  Partials           ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-xiaoyao
Copy link
Copy Markdown
Contributor Author

/re-run api-benchmark

1 similar comment
@adam-xiaoyao
Copy link
Copy Markdown
Contributor Author

/re-run api-benchmark

@adam-xiaoyao
Copy link
Copy Markdown
Contributor Author

/re-run all-failed

Copy link
Copy Markdown
Contributor

@DanielSun11 DanielSun11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForFishes ForFishes merged commit 638c7c3 into PaddlePaddle:develop Apr 1, 2026
138 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants