fix SharedLayerDesc lose attr is_firstly_shared#78680
Merged
ForFishes merged 1 commit intoPaddlePaddle:developfrom Apr 15, 2026
Merged
fix SharedLayerDesc lose attr is_firstly_shared#78680ForFishes merged 1 commit intoPaddlePaddle:developfrom
ForFishes merged 1 commit intoPaddlePaddle:developfrom
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
/re-run all-failed |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #78680 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 2
Lines ? 7
Branches ? 0
===========================================
Hits ? 7
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/re-run all-failed |
1 similar comment
Contributor
Author
|
/re-run all-failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Distributed Strategy
PR Types
Bug fixes
Description
SharedLayerDesc给param设置属性is_firstly_shared的分支由于判断条件有问题导致都没有走入，计算global_grad_norm的时候会重复计算shared weight的梯度，导致global_norm偏大
是否引起精度变化
否