feat: remove git submodules, use CMake FetchContent for C++ deps#1634
Open
Goldziher wants to merge 4 commits intoPaddlePaddle:developfrom
Open
feat: remove git submodules, use CMake FetchContent for C++ deps#1634Goldziher wants to merge 4 commits intoPaddlePaddle:developfrom
Goldziher wants to merge 4 commits intoPaddlePaddle:developfrom
Conversation
- Update ONNX submodule to v1.20.1 (opset 25), onnx-optimizer to v1.5.0, pybind11 to v3.0.2 - Fix protobuf v34 compatibility (SetTotalBytesLimit 2-arg to 1-arg) - Migrate onnxoptimizer includes to onnx/optimizer namespace - Replace removed tryReplacingAllUsesWith with replaceAllUsesWith API - Bump Python minimum to 3.10, add ruff linter config, fix all lint issues - Add pre-commit hooks (gitfluff, ai-rulez, ruff, pyproject-fmt) - Pin dependency version ranges in pyproject.toml
|
Thanks for your contribution! |
This was referenced Mar 14, 2026
- Add SIM112 to ruff ignore list (PaddlePaddle uses lowercase FLAGS_*) - Fix ruff lint errors in debug/ files and notebook - Run ruff format across all files - Remove hardcoded VS 2019 generator from setup.py
Replace git submodules (onnx, optimizer, pybind11, glog) with: - FetchContent for ONNX v1.20.1 and onnx-optimizer v0.3.19 - find_package for pybind11 and glog (system-installed) Also: update tests for PaddlePaddle 3.x, add uv.lock, update docs.
Goldziher
force-pushed
the
feat/cmake-fetchcontent
branch
from
a81b6c7 to
b9241fc
Compare
- Try CONFIG mode for protobuf first, fall back to module mode (Ubuntu 24.04's libprotobuf-dev only provides module mode) - Add pybind11 include dirs to cpp2py_export target so headers are found when pybind11 is installed via pip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
Review and merge in order: #1633 -> this PR -> #1635
CI is expected to pass only on the final PR (#1635), which includes the workflow updates.