Refactor: Centralize and Extend update_model_kwargs_for_generation Logic #2972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralized Highly Common Logic: The following logic, which was duplicated across multiple model subclasses, has been moved into the universal update_model_kwargs_for_generation function:
position_ids update: Logic to increment and append the next position ID for self-attention models.
4D attention_mask support: Extended attention_mask handling to correctly update 4-dimensional masks during generation (in addition to the existing 2D support).
Delete the redundant code in models.The changes were applied only to pure text models, with the exception of Llama.