Skip to content

Update rl_dataset.py with apply_chat_template #10510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Update rl_dataset.py with apply_chat_template #10510

merged 1 commit into from
Apr 28, 2025

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Apr 27, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

PR changes

Description

Copy link

paddle-bot bot commented Apr 27, 2025

Thanks for your contribution!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Apr 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.66%. Comparing base (aad5cbe) to head (a795289).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/datasets/rlhf_datasets/rl_dataset.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10510   +/-   ##
========================================
  Coverage    48.66%   48.66%           
========================================
  Files          768      768           
  Lines       126950   126951    +1     
========================================
+ Hits         61779    61781    +2     
+ Misses       65171    65170    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZHUI ZHUI merged commit d6182ff into develop Apr 28, 2025
10 of 14 checks passed
@ZHUI ZHUI deleted the ZHUI-patch-8 branch April 28, 2025 08:04
@gongel gongel restored the ZHUI-patch-8 branch April 28, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants