-
Notifications
You must be signed in to change notification settings - Fork 823
[CI] refine check_api_label_cn #7256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[CI] refine check_api_label_cn #7256
Conversation
感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-7256.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- ci_scripts/check_api_label_cn.sh: Language not supported
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- ci_scripts/check_api_label_cn.sh: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- ci_scripts/check_api_label_cn.sh: Language not supported
Comments suppressed due to low confidence (1)
ci_scripts/check_api_label_cn.py:170
- [nitpick] The variable name 'API' is ambiguous; consider renaming it to a more descriptive name such as 'relative_api_path' to clarify its purpose.
API = args.doc_root.removesuffix(args.api_root)
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- ci_scripts/check_api_label_cn.sh: Language not supported
Comments suppressed due to low confidence (2)
ci_scripts/check_api_label_cn.py:170
- [nitpick] The variable 'API' is not self-explanatory; consider renaming it to something more descriptive, such as 'api_subpath', to clarify its purpose.
API = args.doc_root.removesuffix(args.api_root)
ci_scripts/check_api_label_cn.py:56
- [nitpick] Consider using a consistent type for 'file_path' (either Path or str) to reduce type handling complexity and improve clarity.
def find_api_labels_in_file(file_path: Path | str) -> list[str]:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- ci_scripts/check_api_label_cn.sh: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- ci_scripts/check_api_label_cn.sh: Language not supported
Comments suppressed due to low confidence (1)
ci_scripts/check_api_label_cn.py:86
- [nitpick] Consider renaming the loop variable 'file' to a more descriptive name (e.g., 'doc_file') to avoid shadowing the built-in 'file' identifier.
for file in files:
Path
to deal with file path