Skip to content

test:coderabit #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rnithinpaladin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test:coderabit #2223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion commons/pac-api-commons/src/test/java/com/tmobile/pacman/api/commons/utils/ForTestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public boolean buildFailureResponse2() {

@SuppressWarnings("rawtypes")
public boolean getAllDatesBetweenDates() throws ParseException {
String currentDate = "01-March-2016";
String currentDate = "05-May-2024";
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to use thread-safe date formatting.

- SimpleDateFormat f = new SimpleDateFormat("dd-MMM-yyyy");
+ DateTimeFormatter f = DateTimeFormatter.ofPattern("dd-MMM-yyyy");

Consider replacing SimpleDateFormat with DateTimeFormatter which is thread-safe and recommended for new code.

Committable suggestion was skipped due low confidence.

SimpleDateFormat f = new SimpleDateFormat("dd-MMM-yyyy");
Date begin = f.parse(currentDate);
List response = DateUtils.getAllDatesBetweenDates(begin, new Date(), "dd/MM/yyyy");
Expand Down