feat:[NEXT-1926] Added Optional tags

[arunpaladin]

feat:NEXT-1926 Added Optional tags

Summary by CodeRabbit

• Chores
  • Simplified tag handling by combining mandatory and optional tags into a single list, streamlining how display fields and filters are computed in the database.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR updates the DB.sql installation script to pass a single comma-separated tag list (merged mandatory and optional tags via CONCAT_WS(',', NULLIF(TRIM(@MANDATORY_TAGS),''), NULLIF(TRIM(@OPTIONAL_TAGS),''))) to two tag-related stored procedures instead of separate tag parameters.

Changes

Cohort / File(s)	Summary
Tag Parameter Consolidation installer/resources/pacbot_app/files/DB.sql	Calls to update_displayFields_for_azure_gcp and update_filter_for_tag now use CONCAT_WS(',', NULLIF(TRIM(@MANDATORY_TAGS),''), NULLIF(TRIM(@OPTIONAL_TAGS),'')) to provide a single merged tag list instead of passing mandatory and optional tags separately.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• feat:[NEXT-1926] Added Optional tags to PolicyEngine #2387: Adds OPTIONAL_TAGS usage; this PR uses OPTIONAL_TAGS when merging tag lists passed to procedures.
• feat:[NEXT-1926] Added Optional tags #2388: Also edits DB.sql tag-handling calls; closely related refactor of how tag parameters are passed.

Suggested reviewers

• kevin-paladin

Poem

🐰 I stitched two tag-strings in a hop and a jig,
CONCAT_WS hummed, tidy and big,
Mandatory, optional — now hand in glove,
One list to rule filters and fields thereof,
Hooray for neat SQL — a rabbit's small jig!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete and lacks essential details required by the template, including problem statement, solution explanation, testing information, and checklist items.	Complete the description by adding Problem, Solution, testing details, type of change checkbox, and verification checklist as specified in the template.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly relates to the main change, which adds support for optional tags by merging mandatory and optional tag lists in the database procedures.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@installer/resources/pacbot_app/files/DB.sql`:
- Line 2849: The call to update_displayFields_for_azure_gcp(CONCAT_WS(',',
`@MANDATORY_TAGS`, `@OPTIONAL_TAGS`)) can produce an extra empty tag when
`@OPTIONAL_TAGS` = '' because CONCAT_WS will include an empty value; update the
call or the procedure to guard against empty optional-tags by normalizing empty
strings to NULL before concatenation (e.g., set `@OPTIONAL_TAGS` =
NULLIF(`@OPTIONAL_TAGS`, '')) or alter update_displayFields_for_azure_gcp and the
sibling procedure to skip any empty tag entries inside their tag-parsing loops
(check for '' or NULL before inserting into tags) so no invalid empty
tags/filters are inserted.