Skip to content

feat:[PEA-1473] Exemption field name updated. - #2405

Merged
arunpaladin merged 1 commit into
masterfrom
fix-policy-exemption-field
Jul 28, 2026
Merged

feat:[PEA-1473] Exemption field name updated.#2405
arunpaladin merged 1 commit into
masterfrom
fix-policy-exemption-field

Conversation

@arunpaladin

@arunpaladin arunpaladin commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

feat:PEA-1473 Exemption field name updated.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected expiration date parameter handling for automatic exemptions.
    • Exemption expiration dates can now be retrieved using the expected parameter name.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7c9a1041-dc1b-4688-ba6e-f7e06e313a24

📥 Commits

Reviewing files that changed from the base of the PR and between a50a9b0 and d7267e4.

📒 Files selected for processing (1)
  • jobs/pacman-rule-engine-2.0/src/main/java/com/tmobile/pacman/service/AutoExemptions.java

Walkthrough

The auto-exemption service now retrieves expiration dates using exemptionExpireDate instead of exemptionexpireddate.

Changes

Auto-exemption parameter handling

Layer / File(s) Summary
Update expiration parameter key
jobs/pacman-rule-engine-2.0/src/main/java/com/tmobile/pacman/service/AutoExemptions.java
Updates PARAMS_EXPIRE_DATE_FIELD to use the camelCase expiration-date parameter key.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: its-pravinkhot, kevin-paladin

Poem

A bunny hops through keys so bright,
CamelCase now guides the flight.
Expiry dates find their way,
Through params cleanly every day.
Wiggle ears—what a tidy change!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too brief and omits the template’s required Problem, Solution, testing, and checklist sections. Expand the PR description to include Problem, Solution, Fixes #, type of change, testing steps, checklist items, and any docs or dependency notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the main change: updating the exemption field name.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-policy-exemption-field

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@arunpaladin
arunpaladin enabled auto-merge (squash) July 28, 2026 05:36
@arunpaladin
arunpaladin merged commit b44bfec into master Jul 28, 2026
60 checks passed
@arunpaladin
arunpaladin deleted the fix-policy-exemption-field branch July 28, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants