ci: run sanity checks with next release version set#624
Merged
alperenkose merged 22 commits intoPaloAltoNetworks:developfrom May 23, 2025
Merged
ci: run sanity checks with next release version set#624alperenkose merged 22 commits intoPaloAltoNetworks:developfrom
alperenkose merged 22 commits intoPaloAltoNetworks:developfrom
Conversation
This is to avoid issues with sanity checks passing for the existing version but may not pass for the next release version like deprecated options.
Collaborator
Author
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on Ansible Galaxy and GitHub release
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this PR, sanity checks are run with the updated release files like galaxy.yml which includes the release version (files are temporarily updated just before sanity checks and are not commited).
This avoids the issues with sanity checks passing for the existing version but may not pass for the next release version like deprecated options which are not discovered until published to Redhat AAP.
It also has a fix for ruff E402 check for eda logs.py file.
Motivation and Context
Fixes #620
How Has This Been Tested?
Tested on fork repo.
Types of changes
Checklist