Skip to content

Call BlockRedstoneEvent for more interactions #12206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lulu13022002
Copy link
Contributor

@Lulu13022002 Lulu13022002 commented Feb 28, 2025

Handle more case that would change the powered/power property once a block is placed:

  • skull, copper bulb, bell, target block, note block
  • wind charge on button/lever

Fixes some other problems:

  • lighting strike on lightning rod only called the event for the transition 0 -> 15 and not 15 -> 0
  • command block called the event even for non redstone change (for example when placed/already powered)
  • detector rail called the event with wrong arguments (oldCurrent always equals to newCurrent)
  • trapdoor didn't call the event when already opened then powered
  • door and trapdoor had the real power received instead of its two states (0/15) unlike similar blocks (lever/fence gate)
  • iron/gold pressure plates power change was not accounted properly

@Lulu13022002 Lulu13022002 requested a review from a team as a code owner February 28, 2025 19:32
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Feb 28, 2025
@Lulu13022002 Lulu13022002 force-pushed the feat/more-redstone-event branch 3 times, most recently from 7e75aff to 6f28da7 Compare March 4, 2025 21:14
@github-project-automation github-project-automation bot moved this from Awaiting review to Awaiting final testing in Paper PR Queue Mar 5, 2025
@Lulu13022002 Lulu13022002 force-pushed the feat/more-redstone-event branch 3 times, most recently from 6b0123a to 335adcd Compare March 6, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Awaiting final testing
Development

Successfully merging this pull request may close these issues.

3 participants