Call EntityDamageByBlockEvent for fire damage #12235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulu13022002
force-pushed
the
feat/fire-damage-block-event
branch
2 times, most recently
from
aa2d861 to
90aa40c
Compare
Lulu13022002
force-pushed
the
feat/fire-damage-block-event
branch
from
90aa40c to
8e7b1d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense to have the more specific event called here since lava damage also called the event.
Also deprecated the unused dragon breath damage cause to warn listeners (it's only used for command or plugin but not for the dragon breath in a regular play) will probably be fixed in https://bugs.mojang.com/browse/MC/issues/MC-84595.