Skip to content

Add QOL InventoryView#open method #12281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Y2Kwastaken
Copy link
Contributor

This PR is fairly simple and just adds a open method to InventoryView. Seeing as InventoryView has a single non changeable non null player on it to begin with this is extremely nice with the InventoryViewBuilders.

// Before

player.openInventory(MenuType.GENERIC_9X3.builder()
	.location(location)
	.title(Component.text("This is my awesome InventoryView"))
	.build(player));

// After

MenuType.GENERIC_9X3.builder()
	.location(location)
	.title(Component.text("This is my awesome InventoryView"))
	.build(player)
	.open();

@Y2Kwastaken Y2Kwastaken requested a review from a team as a code owner March 12, 2025 22:30
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Mar 12, 2025
@github-project-automation github-project-automation bot moved this from Awaiting review to Closed in Paper PR Queue Mar 12, 2025
@Y2Kwastaken Y2Kwastaken deleted the feature/better-invview-open branch March 12, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

1 participant