Fix unnecessary map data saves (#12295)

[Dqu1J]

Fixes #12295

Currently, MapCanvas API unnecessarily causes map data file to save.

The API calls this.mapView.worldMap.setColorsDirty() to mark colors dirty for players, however this has the side-effect of saving the map .dat files as well:

public void setColorsDirty(int x, int z) {
    this.setDirty(); // This saves the data file! 

    for (MapItemSavedData.HoldingPlayer holdingPlayer : this.carriedBy) {
        holdingPlayer.markColorsDirty(x, z); // This is what the API wants to do!
    }
}

This causes unnecessary lag during world saves, which scales with the amount of maps handled with API since last save. On servers that heavily rely on imageonmap-like plugins, it can cause lag spikes of dozens of seconds.

This PR changes this method to add a boolean argument to the method that determines whether the file is saved or not, which is used by the API. An overload is added for compatibility, and for vanilla.

[FireInstall]

Is it really safe to never save the data after any changes where done here?
I mean wouldn't that break the expectations of current plugins?
And if yes, maybe pulling up a "doNotSave" optional parameter into the API?

[Dqu1J]

@FireInstall custom renderers never end up saving data to .dat files afaik
quoting what Warriorrrr told me on discord, "drawing the image only modifies the buffer inside the craft canvas and not the underlying colors array the game saves"

[FireInstall]

alright, if not only drawing but also chaning pixels should not save, then thanks!
In that case this can get marked as resolved. Have a nice day ~