Skip to content

Configuration API #12301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Configuration API #12301

wants to merge 6 commits into from

Conversation

Owen1212055
Copy link
Member

Please provide feedback on naming, and general event consensis.

But my goal is to have the following:

  • Full cookie getting/setting support in the login/config/play stage. This means you'll be able to disconnect players during LOGIN depending on sent cookies. (Bukkit only allows play stage, and PARTLY config stage) (CookieConnection)
  • Allowing to boot players into the config stage/ out of it
  • Allow to add custom configuration tasks, so for example being able to load player data. (AsyncPlayerConnectionConfigurateEvent)
  • Allowing to load resource packs during config stage better
  • Transfer the player in config/player
  • send custom report details (shown in client debug log)

@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Mar 15, 2025
@Warriorrrr Warriorrrr added type: feature Request for a new Feature. scope: api labels Mar 17, 2025
@kennytv kennytv requested a review from Copilot April 14, 2025 09:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 45 out of 46 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • paper-api-generator.settings.gradle.kts: Language not supported
Comments suppressed due to low confidence (3)

paper-api/src/main/java/org/bukkit/event/player/PlayerLoginEvent.java:22

  • The deprecation version 'idk' is unclear; please update it to a proper version string to improve clarity.
@Deprecated(since = "idk")

paper-api/src/main/java/io/papermc/paper/event/connection/configuration/PlayerConfigurationConnectionEvent.java:8

  • [nitpick] The field 'loginConnection' should be renamed to 'configurationConnection' to better reflect its purpose in a configuration event.
private final PlayerConfigurationConnection loginConnection;

paper-api/src/main/java/io/papermc/paper/connection/PlayerCommonConnection.java:3

  • [nitpick] Consider clarifying the name of this interface to more clearly describe its purpose, such as 'PlayerSharedConnection' or a similar term.
// TODO: Naming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: api type: feature Request for a new Feature.
Projects
Status: Awaiting review
Development

Successfully merging this pull request may close these issues.

2 participants