Expose more data for MusicInstrument #12415
Open
+85
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Doc94 to still looking into this, still waiting for it to get into Paper so I can finally get those custom goat horn working like I want them 🤣 |
kennytv
reviewed
Apr 13, 2025
| * | ||
| * @return a sound | ||
| */ | ||
| public abstract Sound getSoundEvent(); |
There was a problem hiding this comment.
I'd just call it getSound instead of SoundEvent
There was a problem hiding this comment.
Hmm just the method not?
I set this name for avoid confusing for what this get and make consist with the create instrument PR.
Owen1212055
approved these changes
May 1, 2025
github-project-automation
bot
moved this from Awaiting review
to Awaiting final testing
in Paper PR Queue
okay this and with the Kenny comment i rename the method |
kennytv
reviewed
May 18, 2025
paper-server/src/main/java/org/bukkit/craftbukkit/CraftMusicInstrument.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR take the base of #11925 for expose the data in MusicInstrument for keep the old PR just for create new ones when support exists.