-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Flying monster tracking range #13375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Flying monster tracking range #13375
Conversation
lynxplay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably also then extend the paper y tracking range config options.
Good catch. Fixed now |
|
A question that I cannot answer right now is how sane the defaulting is. For your spigot implementation that works fine (as long as the default val for flying monsters and monsters never diverge which, fair). The paper one is a bit more confusing as But I need more time to think about that which is not around given .11 releases on the 9th 😅 |
They are essentially the same as ghasts, large, flying monsters, they don't currently get included because happyghast doesn't extend ghast for some reason, this fixes that
|
Also fixed happy ghasts not being categorized as flying monsters, they should be since they are essentially the same as ghasts, large, flying monsters. The only reason it doesn't work currently is because Mojang didn't make happy ghast extend ghast for some reason. |
The happy ghast is not a monster, tho. Monsters are everything that's an enemy, and the happy ghast is the entire opposite. It not extending ghast also makes sense. Happy ghast extends ageable and normal ghasts aren't ageable. Happy ghasts have entirely different goal selectors, are ridable, have different sounds, different interactions with players and don't have the ability to shoot fireballs. Its a completely different mob with a similar name. |
Flying monsters are their own category for entity activation, but, for some strange reason they are bundled with regular monsters for entity tracking.
This is a problem because ghasts pop in very noticeably due to their size, this PR adds a way to increase their tracking range specifically to alleviate this issue.
If not set in the config, it will default to the old behavior of using monster tracking range.