Skip to content

Conversation

@NewwindServer
Copy link
Contributor

@NewwindServer NewwindServer commented Dec 7, 2025

Flying monsters are their own category for entity activation, but, for some strange reason they are bundled with regular monsters for entity tracking.

This is a problem because ghasts pop in very noticeably due to their size, this PR adds a way to increase their tracking range specifically to alleviate this issue.

If not set in the config, it will default to the old behavior of using monster tracking range.

@NewwindServer NewwindServer requested a review from a team as a code owner December 7, 2025 00:13
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Dec 7, 2025
Copy link
Contributor

@lynxplay lynxplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably also then extend the paper y tracking range config options.

@github-project-automation github-project-automation bot moved this from Awaiting review to Changes required in Paper PR Queue Dec 7, 2025
@NewwindServer
Copy link
Contributor Author

Should probably also then extend the paper y tracking range config options.

Good catch. Fixed now

@lynxplay lynxplay moved this from Changes required to PR Party candidate in Paper PR Queue Dec 7, 2025
@lynxplay
Copy link
Contributor

lynxplay commented Dec 7, 2025

A question that I cannot answer right now is how sane the defaulting is.
Making these things their own category obviously means we do wanna use what people currently have for values.

For your spigot implementation that works fine (as long as the default val for flying monsters and monsters never diverge which, fair). The paper one is a bit more confusing as default generally means "what vanilla goes with", which kinda breaks here. For paper configs we have migration tooling around already so it might be better to register a new config version and pre-fill existing configs with their current monster value.

But I need more time to think about that which is not around given .11 releases on the 9th 😅

They are essentially the same as ghasts, large, flying monsters, they don't currently get included because happyghast doesn't extend ghast for some reason, this fixes that
@NewwindServer
Copy link
Contributor Author

Also fixed happy ghasts not being categorized as flying monsters, they should be since they are essentially the same as ghasts, large, flying monsters. The only reason it doesn't work currently is because Mojang didn't make happy ghast extend ghast for some reason.

@davidmayr
Copy link
Contributor

Also fixed happy ghasts not being categorized as flying monsters, they should be since they are essentially the same as ghasts, large, flying monsters. The only reason it doesn't work currently is because Mojang didn't make happy ghast extend ghast for some reason.

The happy ghast is not a monster, tho. Monsters are everything that's an enemy, and the happy ghast is the entire opposite.

It not extending ghast also makes sense. Happy ghast extends ageable and normal ghasts aren't ageable. Happy ghasts have entirely different goal selectors, are ridable, have different sounds, different interactions with players and don't have the ability to shoot fireballs. Its a completely different mob with a similar name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: PR Party candidate

Development

Successfully merging this pull request may close these issues.

3 participants