Skip to content

Create a HTTP Client per worker thread instead of per connection - #1866

Open
Beaness wants to merge 1 commit into
PaperMC:dev/4.0.0from
PvPRivals:httpclient
Open

Create a HTTP Client per worker thread instead of per connection#1866
Beaness wants to merge 1 commit into
PaperMC:dev/4.0.0from
PvPRivals:httpclient

Conversation

@Beaness

@Beaness Beaness commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This uses one HttpClient per worker thread instead of creating one for every connection or sharing a single client globally.

This should still avoid the concurrent stream issue from #1243, since requests are distributed across the worker threads. At the same time, each worker can reuse its client and connections, which reduces overhead and avoids repeatedly setting up new TCP connections and TLS handshakes. This saves some network round trips to Mojang and should reduce login times.

@electronicboy

Copy link
Copy Markdown
Member

The problem we had is that the connections would die and the http client wouldn't restore them, this IS supposed to be thread safe but the client is so fragile that we end up just recreating them instead. I don't think I could merge this without reputable people testing it in their environments for a long period of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants