Create a HTTP Client per worker thread instead of per connection - #1866
Open
Beaness wants to merge 1 commit into
Open
Create a HTTP Client per worker thread instead of per connection#1866Beaness wants to merge 1 commit into
Beaness wants to merge 1 commit into
Conversation
Member
|
The problem we had is that the connections would die and the http client wouldn't restore them, this IS supposed to be thread safe but the client is so fragile that we end up just recreating them instead. I don't think I could merge this without reputable people testing it in their environments for a long period of time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses one HttpClient per worker thread instead of creating one for every connection or sharing a single client globally.
This should still avoid the concurrent stream issue from #1243, since requests are distributed across the worker threads. At the same time, each worker can reuse its client and connections, which reduces overhead and avoids repeatedly setting up new TCP connections and TLS handshakes. This saves some network round trips to Mojang and should reduce login times.