Skip to content

fix(api): Unbound profileProperties Collection #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kezz merged 1 commit into from
Nov 12, 2025
Merged

fix(api): Unbound profileProperties Collection #1337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/java/net/kyori/adventure/text/object/PlayerHeadObjectContents.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ sealed interface Builder permits PlayerHeadObjectContentsImpl.BuilderImpl {
* @since 4.25.0
*/
@Contract(value = "_ -> this")
Builder profileProperties(final Collection<ProfileProperty> properties);
Builder profileProperties(final Collection<? extends ProfileProperty> properties);

/**
* Sets the skin (name, id, properties, and texture) from the given source, overriding any existing values.
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/net/kyori/adventure/text/object/PlayerHeadObjectContentsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public Builder profileProperty(final ProfileProperty property) {
}

@Override
public Builder profileProperties(final Collection<ProfileProperty> properties) {
public Builder profileProperties(final Collection<? extends ProfileProperty> properties) {
for (final ProfileProperty property : requireNonNull(properties, "properties")) {
this.profileProperty(property);
}
Expand Down