Skip to content

feat: external URL improvements #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 22, 2025
Merged

feat: external URL improvements #598

merged 11 commits into from
May 22, 2025

Conversation

Doc94
Copy link
Contributor

@Doc94 Doc94 commented May 21, 2025

This PR try a few things related to external URL

  • Fix currently broken URLs
  • Try to add a check for notice this in builds/checks

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview bbc862b

@zlataovce zlataovce self-assigned this May 21, 2025
zlataovce
zlataovce requested changes May 21, 2025
View reviewed changes
Copy link
Member

@zlataovce zlataovce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the linting step seems to add quite a bit of time to the build (+ 1m 30s) and the fact that its requests are mostly blocked by Cloudflare renders it basically useless

otherwise LGTM without the lint step

@zlataovce zlataovce merged commit 9d3b412 into PaperMC:main May 22, 2025
3 checks passed
@Doc94 Doc94 deleted the feature/url-checks branch May 24, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zlataovce zlataovce zlataovce approved these changes

Assignees

@zlataovce zlataovce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Doc94 @zlataovce