Merged
Conversation
Member
MiniDigger
commented
Jun 30, 2025
MiniDigger
commented
- if last build has no commits
- if first build in a version
* if last build has no commits * if first build in a version
There was a problem hiding this comment.
Pull Request Overview
This PR improves edge case handling for builds and commit gathering while introducing a new version response model.
- Adds a new VersionResponse record to model version data.
- Refactors commit collection in PublishToFillTask to address edge cases for builds without commits and the first build in a version.
- Updates error messages to include more detailed exception information.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/io/papermc/fill/model/response/v3/VersionResponse.java | Introduces Java record classes for version responses. |
| src/main/java/io/papermc/fill/gradle/task/PublishToFillTask.java | Refactors commit gathering logic and improves error handling with detailed messages. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.