Apply a specific rule to exclude JUnit #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octylFractal
force-pushed
the
bugfix/reduce-junit-exclusion-impact
branch
from
7f62d78
to
bee8002
Compare
|
Would applying the rule to the |
|
Upon closer review, I'm not sure this exclusion even necessary anymore? It seems like paper-api has been excluding junit from json-simple since before dev bundle version 2 (the latest supported by paperweight), so this code doesn't actually do anything. Perhaps this can just be deleted? |
This avoids excluding junit from the test classpath, even if explicitly added by a downstream user, which doesn't make sense, and allows people to add junit to the main classpath if they need to for some reason.
jpenilla
force-pushed
the
bugfix/reduce-junit-exclusion-impact
branch
from
bee8002
to
421af88
Compare
jpenilla
approved these changes
Apr 29, 2024
jpenilla
force-pushed
the
bugfix/reduce-junit-exclusion-impact
branch
from
3a9610a
to
421af88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids excluding junit from the test classpath, even if explicitly added by a downstream user, which doesn't make sense, and allows people to add junit to the main classpath if they need to for some reason.