Skip to content

Conversation

@MiniDigger
Copy link
Member

@MiniDigger MiniDigger commented Jan 6, 2024

just opened to make reviewing the pending diff easier

### ToDo
- [x] restamp sometimes runs oom, maybe move it to a worker queue? (misisng in setupvanilla)
- [x] don't delete git dirs (fails on windows), instead properly git reset and redo stuff
- [x] more tests (for lib patches for example)
- [x] figure out why build fails (maybe try deploying locally)
- [x] fix tests
- [x] patch libs
- [x] Make sure resource files have a new line at the end
- [x] rebuilding seams to put the diff in both source and feature patches (need to do a git reset to the file commit but also keep uncommited diff?)
- [x] rebuild file patches needs to git add
- [x] `:remapMache` fails for the first time, need to run :extractFromBundler first (minecraft classpath is empty because project dependencies have already been resolved by that point and they are empty because no lib file was present at that time)
- [ ] paperweight-patcher
- [ ] tests for paperweight-patcher
- [ ] paperweight-userdev
- [ ] get minecraft version from mache instead of relying on the extension
- [ ] check that packaging and publishing works
- [x] nbt files seem broken
- [ ] split setupvanilla into more tasks maybe?

@MiniDigger MiniDigger force-pushed the softspoon-v2 branch 2 times, most recently from a1590bf to ae08a55 Compare January 14, 2024 09:47
@MiniDigger MiniDigger force-pushed the softspoon-v2 branch 4 times, most recently from 063f21b to 7481b87 Compare March 30, 2024 10:52
@MiniDigger MiniDigger force-pushed the softspoon-v2 branch 3 times, most recently from 3c6d8b0 to a7412cf Compare October 26, 2024 10:17
@MiniDigger MiniDigger force-pushed the softspoon-v2 branch 8 times, most recently from 3d1b784 to f941ce4 Compare November 2, 2024 15:33
@MiniDigger MiniDigger force-pushed the softspoon-v2 branch 4 times, most recently from 9d67b21 to 810f4f1 Compare December 1, 2024 09:34
MiniDigger and others added 3 commits December 6, 2024 12:32
- Test with 1.21.4
- Apply paperweight to -server, not root
- Rework mc classpath to use mache variants
- Don't try to resolve implementation
We only need to add the mache repo and any repos declared in it's meta

mache repo: needs propagation to userdev config

any other repos should be declared in paper itself and also added to the dev bundle library repos
@electronicboy electronicboy deleted the branch main December 13, 2024 21:02
@electronicboy electronicboy deleted the softspoon-v2 branch December 13, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants